Alex Dunn

Results 115 comments of Alex Dunn

For reference, we are still waiting on @ziyan1996 to make a call on whether their License will allow this or not

@computron Should prechecks have the ability to be skipped though? AFAIK they can be all be *super* fast operations that (1) pass (2) fail or (3) throw an error. If...

Yes - I think all featurizers can have a precheck that never skips. I don't see any operations where just checking if the featurizer will take a long time will...

This is weird, though I'm not sure its a windows issue. I think it is something having to do with downloading from the same IP from figshare and the file...

That’s an excellent idea, I will try that! Thanks, Alex On Aug 12, 2022 at 5:07 PM -0700, Sterling Baird ***@***.***>, wrote: > Since it seems to be an issue...

Hi @sgbaird thanks for the PR! This looks great and it is encouraging to see it basically in a working form already. I think it is preferable to have the...

@sgbaird ### External dependencies For `chem_wasserstein` on PyPi, I think it's totally fine to just reference it as an external dependency and ElM2D can live in `featurizers.composition.external.elm2d` (it's own module)....

Hey @sgbaird any thoughts on this? Should I close?

> Sorry, I kind of dropped the ball on this. Thank you for the reminder! I think I'll reference it as an external dependency for now. I'll plan on getting...