setup-arduino-cli icon indicating copy to clipboard operation
setup-arduino-cli copied to clipboard

update to node16 (node12 support deprecated)

Open henrygab opened this issue 2 years ago • 2 comments

See https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

Every user of this action is now getting warnings (not yet errors). For example:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: arduino/setup-arduino-cli

I have verified this small change removes this warning when I point to this PR branch. Given the simplicity of the fix, I hope that's sufficient.

henrygab avatar Oct 21 '22 03:10 henrygab

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 21 '22 03:10 CLAassistant

  • Update package-lock.json file to the lockfileVersion 2 data format used by Node.js 16.x
  • Update the unit test workflow to run the tests using Node.js 16.x (it is currently using 10.x 👴)

I updated the test runner to install Node 16.x instead of Node 10.x. I realize that validation is still necessary, and I am not familiar enough to attempt the lockfile changes. (while I love learning, time is a limiting factor.)

Thank you for self-assigning!

henrygab avatar Oct 21 '22 19:10 henrygab

I am getting this warning, too. @per1234 are there any remaining issues? AFAICS the changed requested have now been made. It would be great to make a release with to address the warning.

astraw avatar Dec 16 '22 19:12 astraw

Is there anything left to do before this can get merged and released? It would be great to get rid of the warnings...

lhstrh avatar Feb 15 '23 21:02 lhstrh

What is the status on this. I am a beginner at Github Actions so it may be my fault, but the action is now broken? Do I have to used a differenct verison of the action?

ChanceCuddeback avatar Apr 24 '23 18:04 ChanceCuddeback

@ChanceCuddeback This action is still working for me here, though there are warnings that the action will stop working soon, so I hope it is fixed soon. Thank you Arduino Team for all your work.

joshua-8 avatar Apr 24 '23 18:04 joshua-8

Closing as superseded by https://github.com/arduino/setup-arduino-cli/pull/54

per1234 avatar Oct 03 '23 21:10 per1234