docs-content icon indicating copy to clipboard operation
docs-content copied to clipboard

Removing validation on main

Open lukdog opened this issue 9 months ago • 3 comments

What This PR Changes

We 're spending a lot of minutes of GH action also slowing down other jobs for content validation on main. It is not really important because the validation is already performed on PRs, and the content can not be merged if the validation in PR fails.

Contribution Guidelines

lukdog avatar Apr 29 '24 15:04 lukdog

@lukdog does this mean that the validations won't run on a "push to production" action but we'll still have them on PRs?

jhansson-ard avatar Apr 30 '24 06:04 jhansson-ard

@lukdog does this mean that the validations won't run on a "push to production" action but we'll still have them on PRs?

At the moment the Validation was not running on deploy to production, but only after a merge to main branch. I think it is not really needed because the PRs are already checked, and no-one is checking the status of this validation after merge.

But maybe, a good idea can be to apply this, but add the validation on deploy, blocking non valid content. WDYT?

lukdog avatar Apr 30 '24 07:04 lukdog

Yes, then we can remove this - like you said, the PRs should already be checked. If the validation breaks there we should not be able to push to main :)

jhansson-ard avatar Apr 30 '24 08:04 jhansson-ard