arduino-create-agent icon indicating copy to clipboard operation
arduino-create-agent copied to clipboard

/update endpoint does not work properly on macos

Open umbynos opened this issue 4 years ago • 0 comments

Bug Report

Describe the bug

When a POST request is sent to the agent on macos to the /update endpoint the communication is truncated because systray is run in the main thread and causes the gin goroutine to not exit gracefully. This behaviour is present only in the mac os version 🤷🏼‍♂️

To Reproduce

curl -X POST http://127.0.0.1:8991/update on macos version

Expected behavior

get {"success":"Please wait a moment while the agent reboots itself"} instead of connection closed

Environment (please complete the following information):

  • OS [e.g. Windows]: MacOS
  • OS version: 11 (Big Sur)
  • Browser [e.g. chrome, safari]: not a browser related problem
  • Browser Version:
  • Agent Version [e.g. 1.0.0]: 1.2.0

Additional context

umbynos avatar Jan 28 '21 14:01 umbynos