arduino-cli icon indicating copy to clipboard operation
arduino-cli copied to clipboard

Use `buf.build` to manage our protobuf related activities

Open alessio-perugini opened this issue 1 year ago • 2 comments
trafficstars

Please check if the PR fulfills these requirements

See how to contribute

  • [ ] The PR has no duplicates (please search among the Pull Requests before creating one)
  • [ ] The PR follows our contributing guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)
  • [ ] UPGRADING.md has been updated with a migration guide (for breaking changes)
  • [ ] configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Use buf to manage the compilation, lint, formatting, breaking change detection of our protobuf files

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

If this PR gets approved I will also have to update our template repo

alessio-perugini avatar Oct 18 '24 16:10 alessio-perugini

The latest Buf updates on your PR. Results from workflow Check Protocol Buffers / check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedOct 21, 2024, 3:19 PM

github-actions[bot] avatar Oct 18 '24 16:10 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.65%. Comparing base (a527c7c) to head (e1794eb). Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2736      +/-   ##
==========================================
- Coverage   67.67%   67.65%   -0.02%     
==========================================
  Files         236      236              
  Lines       22327    22327              
==========================================
- Hits        15109    15106       -3     
- Misses       6030     6032       +2     
- Partials     1188     1189       +1     
Flag Coverage Δ
unit 67.65% <ø> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 18 '24 16:10 codecov[bot]