arduino-cli icon indicating copy to clipboard operation
arduino-cli copied to clipboard

Added more lint checks and fixed some warnings.

Open cmaglie opened this issue 1 year ago • 1 comments
trafficstars

Please check if the PR fulfills these requirements

See how to contribute

  • [X] The PR has no duplicates (please search among the Pull Requests before creating one)
  • [X] The PR follows our contributing guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)
  • [ ] UPGRADING.md has been updated with a migration guide (for breaking changes)
  • [ ] configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

  • The biggest part of this PR is fixing small Printf-style formatting errors in the translations, previously those imperfections were very subtle to detect because they are tricky to do right and the linter was silenced.
  • Eliminated an unreachable block of code
  • Enabled a lot of other minor lint checks

What is the current behavior?

No change

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

cmaglie avatar May 21 '24 11:05 cmaglie

Codecov Report

Attention: Patch coverage is 53.13433% with 471 lines in your changes are missing coverage. Please review.

Project coverage is 70.26%. Comparing base (ba19a2d) to head (7a20b71). Report is 1 commits behind head on master.

Files Patch % Lines
internal/arduino/cores/packagemanager/loader.go 3.84% 25 Missing :warning:
.../arduino/cores/packagemanager/install_uninstall.go 42.85% 24 Missing :warning:
commands/cmderrors/cmderrors.go 42.10% 22 Missing :warning:
commands/instances.go 18.51% 22 Missing :warning:
internal/arduino/builder/sizer.go 15.00% 17 Missing :warning:
internal/cli/lib/search.go 45.16% 17 Missing :warning:
internal/arduino/cores/packagemanager/profiles.go 20.00% 16 Missing :warning:
commands/service_upload.go 48.00% 13 Missing :warning:
...al/arduino/cores/packagemanager/package_manager.go 40.00% 12 Missing :warning:
internal/arduino/cores/status.go 0.00% 12 Missing :warning:
... and 93 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2610      +/-   ##
==========================================
- Coverage   70.30%   70.26%   -0.04%     
==========================================
  Files         222      222              
  Lines       21262    21262              
==========================================
- Hits        14948    14940       -8     
- Misses       5131     5147      +16     
+ Partials     1183     1175       -8     
Flag Coverage Δ
unit 70.26% <53.13%> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 21 '24 12:05 codecov[bot]