arduino-cli
arduino-cli copied to clipboard
Added more lint checks and fixed some warnings.
trafficstars
Please check if the PR fulfills these requirements
- [X] The PR has no duplicates (please search among the Pull Requests before creating one)
- [X] The PR follows our contributing guidelines
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ]
UPGRADING.mdhas been updated with a migration guide (for breaking changes) - [ ]
configuration.schema.jsonupdated if new parameters are added.
What kind of change does this PR introduce?
- The biggest part of this PR is fixing small Printf-style formatting errors in the translations, previously those imperfections were very subtle to detect because they are tricky to do right and the linter was silenced.
- Eliminated an unreachable block of code
- Enabled a lot of other minor lint checks
What is the current behavior?
No change
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
No
Other information
Codecov Report
Attention: Patch coverage is 53.13433% with 471 lines in your changes are missing coverage. Please review.
Project coverage is 70.26%. Comparing base (
ba19a2d) to head (7a20b71). Report is 1 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #2610 +/- ##
==========================================
- Coverage 70.30% 70.26% -0.04%
==========================================
Files 222 222
Lines 21262 21262
==========================================
- Hits 14948 14940 -8
- Misses 5131 5147 +16
+ Partials 1183 1175 -8
| Flag | Coverage Δ | |
|---|---|---|
| unit | 70.26% <53.13%> (-0.04%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.