arduino-cli
arduino-cli copied to clipboard
[skip-changelog] Migrate tests from `test_compile_part_1.py` to `compile_part_1_test.go`
Please check if the PR fulfills these requirements
- [x] The PR has no duplicates (please search among the Pull Requests before creating one)
- [x] The PR follows our contributing guidelines
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ]
UPGRADING.mdhas been updated with a migration guide (for breaking changes)
What kind of change does this PR introduce?
Infrastructure Enhancement
What is the new behavior?
This PR is a followup to PR #1806 Integration tests that were previously present in test_compile_part_1.py have been rewritten in compile_part_1_test.go, without changing their original purpose. The tests are the following:
- TestCompileWithoutFqbn
- TestCompileErrorMessage
- TestCompileWithSimpleSketch
- TestOutputFlagDefaultPath
- TestCompileWithSketchWithSymlinkSelfloop
- TestCompileBlacklistedSketchname
- TestCompileWithoutPrecompiledLibraries
- TestCompileWithBuildPropertiesFlag
- TestCompileWithBuildPropertyContainingQuotes
- TestCompileWithMultipleBuildPropertyFlags
Does this PR introduce a breaking change, and is titled accordingly?
No
Codecov Report
Base: 36.58% // Head: 36.60% // Increases project coverage by +0.02% :tada:
Coverage data is based on head (
356e5d9) compared to base (5730e2e). Patch coverage: 100.00% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## master #1861 +/- ##
==========================================
+ Coverage 36.58% 36.60% +0.02%
==========================================
Files 231 231
Lines 19696 19698 +2
==========================================
+ Hits 7206 7211 +5
+ Misses 11659 11657 -2
+ Partials 831 830 -1
| Flag | Coverage Δ | |
|---|---|---|
| unit | 36.60% <100.00%> (+0.02%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| internal/integrationtest/arduino-cli.go | 85.45% <100.00%> (+0.10%) |
:arrow_up: |
| arduino/cores/packagemanager/package_manager.go | 66.58% <0.00%> (+0.75%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Tests have been updated. They are now using the copy sketch function when necessary.