arduino-cli icon indicating copy to clipboard operation
arduino-cli copied to clipboard

[skip-changelog] Migrate tests from `test_board.py` to `board_test.go`

Open MatteoPologruto opened this issue 3 years ago • 1 comments
trafficstars

Please check if the PR fulfills these requirements

  • [x] The PR has no duplicates (please search among the Pull Requests before creating one)
  • [x] The PR follows our contributing guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)
  • [ ] UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Infrastructure enhancement

What is the new behavior?

This PR is a followup to PR #1806 Integration tests that were previously present in test_board.py have been rewritten in board_test.go, without changing their original purpose. The tests are the following:

  • TestBoardList
  • TestBoardListWithInvalidDiscovery
  • TestBoardListall
  • TestBoardListallWithManuallyInstalledPlatform
  • TestBoardDetails
  • TestBoardDetailsNoFlags
  • TestBoardDetailsListProgrammersWithouthFlags
  • TestBoardDetailsListProgrammersFlags
  • TestBoardSearch
  • TestBoardAttachWithoutSketchJson
  • TestBoardSearchWithOutdatedCore

Does this PR introduce a breaking change, and is titled accordingly?

No


See how to contribute

MatteoPologruto avatar Aug 24 '22 07:08 MatteoPologruto

Codecov Report

Base: 36.65% // Head: 36.69% // Increases project coverage by +0.04% :tada:

Coverage data is based on head (9967f32) compared to base (2480d93). Patch has no changes to coverable lines.

:exclamation: Current head 9967f32 differs from pull request most recent head 448a41b. Consider uploading reports for the commit 448a41b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1847      +/-   ##
==========================================
+ Coverage   36.65%   36.69%   +0.04%     
==========================================
  Files         231      231              
  Lines       19683    19699      +16     
==========================================
+ Hits         7215     7229      +14     
+ Misses      11640    11639       -1     
- Partials      828      831       +3     
Flag Coverage Δ
unit 36.69% <ø> (+0.04%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
arduino/monitor/monitor.go 41.05% <0.00%> (-4.74%) :arrow_down:
commands/instances.go 40.04% <0.00%> (+0.40%) :arrow_up:
arduino/cores/packagemanager/package_manager.go 66.58% <0.00%> (+0.75%) :arrow_up:
arduino/resources/index.go 52.57% <0.00%> (+12.37%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Aug 24 '22 07:08 codecov[bot]