ArduinoCore-samd icon indicating copy to clipboard operation
ArduinoCore-samd copied to clipboard

Published 20 hours ago • verified publisher icon arduino

Serial buffer size unchangeable

Open maxgerhardt opened this issue 1 year ago • 3 comments

Per https://github.com/arduino/ArduinoCore-samd/pull/651#issuecomment-1492773652.

Due to the #undef construct done in

https://github.com/arduino/ArduinoCore-samd/blob/a5d52dbf7bcf338de2042eb74cfba33993729c81/cores/arduino/Uart.h#L25-L29

it's not possible to set a global -DSERIAL_BUFFER_SIZE=... value and have it be use used anymore.

A user has a usecase for that here.

maxgerhardt avatar Apr 02 '23 08:04 maxgerhardt

Agreed, it was pretty deleterious to add those.

Muny avatar Jul 21 '23 04:07 Muny

Still seems like the amount of people that care about this is exactly 0.

maxgerhardt avatar Jul 21 '23 09:07 maxgerhardt

Still seems like the amount of people that care about this is exactly 0.

I presume it's because the people who do care about it find ways to work around it. I ended up adding a pre-build step to my project to patch this file.

Muny avatar Jul 21 '23 12:07 Muny