ArduinoCore-sam
ArduinoCore-sam copied to clipboard
arduino
added weak attribute to UART handlers
added weak attribute to UART handlers to allow custom handlers override default UART routine That is vital changes to implement DMX512 protocol over UART (for example) without manual changes of CORE libraries
Hi! is some progress with PR review? That is a real problem now to ask everybody who compiling every project with low-level UART access to fix Arduino libs manually.
hi anklimov, I am having a similar problem for implementing an efficient LIN slave. Would be great if the team merged this (for all Serials)! Georg
Is somebody still alive here? What reason do not accept PR? That is really difficult for users to modify core libraries every time then needed to re-compile project
overwriting the UART ISRs seems to be a common wish as a similar proposal was already made in 2017 (see https://github.com/arduino/ArduinoCore-sam/pull/1, and recently by me (see https://github.com/arduino/ArduinoCore-sam/pull/95. And at least for the latter I have given up and implemented a LIN master handler differently. What a shame!
Hi @gicking It looks you're right - the DUE project is discarded I will appreciated if you share with everybody another option to override default USART handler (i didn't find another option but correct core source again and again to compile my code on DUE)
hi anklimov, actually I am hoping that the Due team is just overwhelmed with other tasks - after all the ARM-based Arduinos are still young, compared to the AVR 8-bitters... Anyway, the effect is the same: pull requests are ignored for a long time at least.
Regarding your question: as discussed in my pull-request #95, the elegant solution would to separate the UART-ISRs such that they can be overwritten by a library to support e.g. attaching user functions via NeoHWSerial. But that would require support by the Due team again... Alternatively, pull request #95 implements this functionality, namely attach an optional user routine to the UART Rx-ISR. Is that what you're looking for?
overwriting the UART ISRs seems to be a common wish as a similar proposal was already made in 2017 (see #1, and recently by me (see #95. And at least for the latter I have given up and implemented a LIN master handler differently. What a shame!
Actually, the MR was open back in 2015, see https://github.com/arduino/Arduino/pull/3023. They really should seriously consider adding more maintainers to this project.
I give up. There is simply no point in contributing to Due core libraries if there is no response within >1 year - or in your example even 5 years! This way the community cannot be kept alive. CU in another project. Over and out...
