ArduinoCore-sam icon indicating copy to clipboard operation
ArduinoCore-sam copied to clipboard

Fix inconsistent function signature in CDC.cpp

Open echtzeit-dev opened this issue 3 years ago • 8 comments

USBAPI.h declares the return type of Serial_::baud() as uint32_t

This causes an error when building the framework with Clang, because it typedefs arm-none-eabi uint32_t to unsigned int and not to unsigned long like gcc-arm-none-eabi.

echtzeit-dev avatar Mar 15 '22 13:03 echtzeit-dev

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 15 '22 13:03 CLAassistant

LGTM, thanks! If you could sign the CLA I'll be glad to merge it immediately :slightly_smiling_face:

facchinm avatar Mar 15 '22 13:03 facchinm

I have 3 more fixes. They are rather small as well. Should I make separate PRs or would you prefer a single one with 3 commits?

echtzeit-dev avatar Mar 15 '22 14:03 echtzeit-dev

FYI: There appears to be lag in the CLA check. I signed it and the page behind link confirms that, but the check here is still pending (even after clicking the recheck link).

echtzeit-dev avatar Mar 15 '22 14:03 echtzeit-dev

Hi @echtzeit-dev. I don't think it is a lag. The check is done against the user who created the commit. That is @weliveindetail, so it is @weliveindetail who must sign the CLA in order for the check to pass.

Hopefully the check will automatically pass once that has been done. If not, please comment here and we will investigate.

per1234 avatar Mar 15 '22 23:03 per1234

Thanks for you note @per1234! It worked.

weliveindetail avatar Mar 16 '22 10:03 weliveindetail

FYI: There appears to be lag in the CLA check. I signed it and the page behind link confirms that, but the check here is still pending (even after clicking the recheck link).

I added them here directly: https://github.com/arduino/ArduinoCore-sam/pull/136#commits-pushed-43df67c

echtzeit-dev avatar Mar 17 '22 09:03 echtzeit-dev

@facchinm Are you still considering to merge this? Otherwise, do you have any questions or change requests? Thx

echtzeit-dev avatar Apr 05 '22 09:04 echtzeit-dev