ArduinoCore-sam icon indicating copy to clipboard operation
ArduinoCore-sam copied to clipboard

adc_set_resolution bug

Open avsteele opened this issue 3 years ago • 0 comments

in adc.c:

void adc_set_resolution(Adc *p_adc,const enum adc_resolution_t resolution)
{
	p_adc->ADC_MR |= (resolution << 4) & ADC_MR_LOWRES;
}

is incorrect. The RHS always evaluates to 0 since the valid values of enum adc_resolution_t as seen in adc.h are 0 (ADC_12_BITS), or 16 (ADC_10_BITS)

avsteele avatar Oct 15 '21 20:10 avsteele