NTPClient icon indicating copy to clipboard operation
NTPClient copied to clipboard

Published 20 hours ago • verified publisher icon arduino-libraries

License missing

Open sebasje opened this issue 4 years ago • 3 comments

I couldn't find a license for this library, could you add this?

sebasje avatar Mar 09 '20 08:03 sebasje

There is an MIT license header in NTPClient.cpp, but adding a LICENSE file so that GitHub shows the correct license is probably better.

jdoe1024 avatar Mar 16 '20 01:03 jdoe1024

I tried adding it, but the automatic option to add MIT license while adding a new file does not seem to be working for me. I think only owner can do that and I do not have the permissions for that.

https://help.github.com/en/github/building-a-strong-community/adding-a-license-to-a-repository is actually a simple guide to add one and can be done to fix this issue. Thanks @jdoe1024

MisterAwesome23 avatar Mar 28 '20 22:03 MisterAwesome23

GitHub's add license feature is convenient, but not required. GitHub's license detection feature works even if you don't use that feature.

You do need to be careful in order to make sure the license will be recognized. The license detection system is picky, which makes sense considering the license is a legal document. If you get the exact text from https://choosealicense.com/licenses/, changing only the copyright line following the indicated format, it will be recognized.

per1234 avatar Mar 29 '20 07:03 per1234