Mouse icon indicating copy to clipboard operation
Mouse copied to clipboard

Create ButtonMouseControl.ino

Open AsherThomasBabu opened this issue 5 years ago • 8 comments

AsherThomasBabu avatar Mar 13 '20 04:03 AsherThomasBabu

One thing to note is that this sketch already comes bundled with the Arduino IDE (and Arduino Web Editor) under File > Examples > 09.USB > Mouse.

It does make sense to bundle the examples with the library since the IDE bundled examples are not available to arduino-cli and Arduino Pro IDE users. I don't like the idea of having duplicate code to maintain, but it also could be problematic to remove the built-in sketches since there are likely tutorials that point people to that menu path. I suppose we could replace the content of the built in sketches with a comment like:

// This example has been moved to File > Examples > Mouse > ButtonMouseControl

per1234 avatar Mar 13 '20 10:03 per1234

I did it thinking that there has to be a consistent codebase throughout, What you have mentioned Is one possible solution to the issue.

AsherThomasBabu avatar Mar 13 '20 10:03 AsherThomasBabu

@per1234 so is it ready to merge?

AsherThomasBabu avatar Mar 13 '20 10:03 AsherThomasBabu

The example itself looks good to me, but I think it would be good to have a decision made regarding how to handle the situation with the built-in examples before moving forward with adding the examples to the Mouse and Keyboard libraries.

I'm not the one to make the decisions on these things. I just added my thoughts in hope they will be of some use.

per1234 avatar Mar 13 '20 10:03 per1234

@per1234 Thanks for the insight! Hoping there will be a decision soon.

AsherThomasBabu avatar Mar 13 '20 10:03 AsherThomasBabu

Oh okay! will keep in mind.

AsherThomasBabu avatar Mar 15 '20 11:03 AsherThomasBabu

@per1234 I've added the files, please let me know if there is anything else. Thanks

AsherThomasBabu avatar Mar 16 '20 08:03 AsherThomasBabu

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 09 '21 13:04 CLAassistant