MKRWAN icon indicating copy to clipboard operation
MKRWAN copied to clipboard

Published 20 hours ago • verified publisher icon arduino-libraries

Fix ABP hangup and add new getters

Open flhofer opened this issue 3 years ago • 19 comments

Changed library version to match firmware v1.2.3, updated firmware with fixes to 1.2.3 from pull request 35

I've fixed a problem where the getJoinStatus function waited forever for a response as it parsed the wrong +OK response still in the buffer. Also a minor issue with the channel mask's char buffer.

Added getters for Power, RSSI, and SNR.

flhofer avatar Apr 28 '21 09:04 flhofer

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 28 '21 09:04 CLAassistant

Memory usage change @ e14aa729bf1bbe0fa1b463ba42ec11953917eec0

Board flash % RAM for global variables %
arduino:mbed_portenta:envie_m4 :small_red_triangle: 0 - +64 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 :small_red_triangle: 0 - +256 0.0 - +0.03 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1300 :small_red_triangle: 0 - +216 0.0 - +0.08 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1310 :small_red_triangle: 0 - +216 0.0 - +0.08 0 - 0 0.0 - 0.0
Click for full report table
Board examples/DumbModemLoraSender
flash		 % examples/DumbModemLoraSender
RAM for global variables		 % examples/FirstConfiguration
flash		 % examples/FirstConfiguration
RAM for global variables		 % examples/LoraSendAndReceive
flash		 % examples/LoraSendAndReceive
RAM for global variables		 % examples/FWUpdaterBridge
flash		 % examples/FWUpdaterBridge
RAM for global variables		 % examples/MKRWANFWUpdate_standalone
flash		 % examples/MKRWANFWUpdate_standalone
RAM for global variables		 %
arduino:mbed_portenta:envie_m4 0 0.0 0 0.0 64 0.01 0 0.0 64 0.01 0 0.0
arduino:mbed_portenta:envie_m7 0 0.0 0 0.0 64 0.01 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 256 0.03 0 0.0
arduino:samd:mkrwan1300 0 0.0 0 0.0 60 0.02 0 0.0 64 0.02 0 0.0 0 0.0 0 0.0 216 0.08 0 0.0
arduino:samd:mkrwan1310 0 0.0 0 0.0 60 0.02 0 0.0 64 0.02 0 0.0 0 0.0 0 0.0 216 0.08 0 0.0
Click for full report CSV 
Board,examples/DumbModemLoraSender<br>flash,%,examples/DumbModemLoraSender<br>RAM for global variables,%,examples/FirstConfiguration<br>flash,%,examples/FirstConfiguration<br>RAM for global variables,%,examples/LoraSendAndReceive<br>flash,%,examples/LoraSendAndReceive<br>RAM for global variables,%,examples/FWUpdaterBridge<br>flash,%,examples/FWUpdaterBridge<br>RAM for global variables,%,examples/MKRWANFWUpdate_standalone<br>flash,%,examples/MKRWANFWUpdate_standalone<br>RAM for global variables,%
arduino:mbed_portenta:envie_m4,0,0.0,0,0.0,64,0.01,0,0.0,64,0.01,0,0.0
arduino:mbed_portenta:envie_m7,0,0.0,0,0.0,64,0.01,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,256,0.03,0,0.0
arduino:samd:mkrwan1300,0,0.0,0,0.0,60,0.02,0,0.0,64,0.02,0,0.0,0,0.0,0,0.0,216,0.08,0,0.0
arduino:samd:mkrwan1310,0,0.0,0,0.0,60,0.02,0,0.0,64,0.02,0,0.0,0,0.0,0,0.0,216,0.08,0,0.0

github-actions[bot] avatar Apr 28 '21 10:04 github-actions[bot]

Memory usage change @ d5823813c0054b6ef072c804f342197e818c2517

Board flash % RAM for global variables %
arduino:mbed_portenta:envie_m4 :small_red_triangle: 0 - +1008 0.0 - +0.1 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 :small_red_triangle: 0 - +1624 0.0 - +0.21 :small_red_triangle: 0 - +8 0.0 - 0.0
arduino:samd:mkrwan1300 :small_red_triangle: 0 - +1528 0.0 - +0.58 :small_red_triangle: 0 - +4 0.0 - +0.01
arduino:samd:mkrwan1310 :small_red_triangle: 0 - +1520 0.0 - +0.58 :small_red_triangle: 0 - +4 0.0 - +0.01
Click for full report table
Board examples/DumbModemLoraSender
flash		 % examples/DumbModemLoraSender
RAM for global variables		 % examples/FirstConfiguration
flash		 % examples/FirstConfiguration
RAM for global variables		 % examples/LoraSendAndReceive
flash		 % examples/LoraSendAndReceive
RAM for global variables		 % examples/FWUpdaterBridge
flash		 % examples/FWUpdaterBridge
RAM for global variables		 % examples/MKRWANFWUpdate_standalone
flash		 % examples/MKRWANFWUpdate_standalone
RAM for global variables		 %
arduino:mbed_portenta:envie_m4 0 0.0 0 0.0 1000 0.1 0 0.0 1008 0.1 0 0.0
arduino:mbed_portenta:envie_m7 0 0.0 0 0.0 1064 0.14 8 0.0 1008 0.13 8 0.0 0 0.0 0 0.0 1624 0.21 0 0.0
arduino:samd:mkrwan1300 0 0.0 0 0.0 992 0.38 4 0.01 948 0.36 4 0.01 0 0.0 0 0.0 1528 0.58 0 0.0
arduino:samd:mkrwan1310 0 0.0 0 0.0 992 0.38 4 0.01 948 0.36 4 0.01 0 0.0 0 0.0 1520 0.58 0 0.0
Click for full report CSV 
Board,examples/DumbModemLoraSender<br>flash,%,examples/DumbModemLoraSender<br>RAM for global variables,%,examples/FirstConfiguration<br>flash,%,examples/FirstConfiguration<br>RAM for global variables,%,examples/LoraSendAndReceive<br>flash,%,examples/LoraSendAndReceive<br>RAM for global variables,%,examples/FWUpdaterBridge<br>flash,%,examples/FWUpdaterBridge<br>RAM for global variables,%,examples/MKRWANFWUpdate_standalone<br>flash,%,examples/MKRWANFWUpdate_standalone<br>RAM for global variables,%
arduino:mbed_portenta:envie_m4,0,0.0,0,0.0,1000,0.1,0,0.0,1008,0.1,0,0.0
arduino:mbed_portenta:envie_m7,0,0.0,0,0.0,1064,0.14,8,0.0,1008,0.13,8,0.0,0,0.0,0,0.0,1624,0.21,0,0.0
arduino:samd:mkrwan1300,0,0.0,0,0.0,992,0.38,4,0.01,948,0.36,4,0.01,0,0.0,0,0.0,1528,0.58,0,0.0
arduino:samd:mkrwan1310,0,0.0,0,0.0,992,0.38,4,0.01,948,0.36,4,0.01,0,0.0,0,0.0,1520,0.58,0,0.0

github-actions[bot] avatar May 11 '21 04:05 github-actions[bot]

Memory usage change @ 64c5bf3f657bda33339779e02678ce46aae75123

Board flash % RAM for global variables %
arduino:mbed_portenta:envie_m4 :small_red_triangle: 0 - +1008 0.0 - +0.1 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 :small_red_triangle: 0 - +1624 0.0 - +0.21 :small_red_triangle: 0 - +8 0.0 - 0.0
arduino:samd:mkrwan1300 :small_red_triangle: 0 - +1528 0.0 - +0.58 :small_red_triangle: 0 - +4 0.0 - +0.01
arduino:samd:mkrwan1310 :small_red_triangle: 0 - +1520 0.0 - +0.58 :small_red_triangle: 0 - +4 0.0 - +0.01
Click for full report table
Board examples/DumbModemLoraSender
flash		 % examples/DumbModemLoraSender
RAM for global variables		 % examples/FirstConfiguration
flash		 % examples/FirstConfiguration
RAM for global variables		 % examples/LoraSendAndReceive
flash		 % examples/LoraSendAndReceive
RAM for global variables		 % examples/FWUpdaterBridge
flash		 % examples/FWUpdaterBridge
RAM for global variables		 % examples/MKRWANFWUpdate_standalone
flash		 % examples/MKRWANFWUpdate_standalone
RAM for global variables		 %
arduino:mbed_portenta:envie_m4 0 0.0 0 0.0 1000 0.1 0 0.0 1008 0.1 0 0.0
arduino:mbed_portenta:envie_m7 0 0.0 0 0.0 1064 0.14 8 0.0 1008 0.13 8 0.0 0 0.0 0 0.0 1624 0.21 0 0.0
arduino:samd:mkrwan1300 0 0.0 0 0.0 992 0.38 4 0.01 948 0.36 4 0.01 0 0.0 0 0.0 1528 0.58 0 0.0
arduino:samd:mkrwan1310 0 0.0 0 0.0 992 0.38 4 0.01 948 0.36 4 0.01 0 0.0 0 0.0 1520 0.58 0 0.0
Click for full report CSV 
Board,examples/DumbModemLoraSender<br>flash,%,examples/DumbModemLoraSender<br>RAM for global variables,%,examples/FirstConfiguration<br>flash,%,examples/FirstConfiguration<br>RAM for global variables,%,examples/LoraSendAndReceive<br>flash,%,examples/LoraSendAndReceive<br>RAM for global variables,%,examples/FWUpdaterBridge<br>flash,%,examples/FWUpdaterBridge<br>RAM for global variables,%,examples/MKRWANFWUpdate_standalone<br>flash,%,examples/MKRWANFWUpdate_standalone<br>RAM for global variables,%
arduino:mbed_portenta:envie_m4,0,0.0,0,0.0,1000,0.1,0,0.0,1008,0.1,0,0.0
arduino:mbed_portenta:envie_m7,0,0.0,0,0.0,1064,0.14,8,0.0,1008,0.13,8,0.0,0,0.0,0,0.0,1624,0.21,0,0.0
arduino:samd:mkrwan1300,0,0.0,0,0.0,992,0.38,4,0.01,948,0.36,4,0.01,0,0.0,0,0.0,1528,0.58,0,0.0
arduino:samd:mkrwan1310,0,0.0,0,0.0,992,0.38,4,0.01,948,0.36,4,0.01,0,0.0,0,0.0,1520,0.58,0,0.0

github-actions[bot] avatar May 11 '21 18:05 github-actions[bot]

Hi! The last commit contains some minor fixes to use the updates on the firmware for 242 HEX bytes send and receive. It should also fix the DR0 stuck data rate for non-ADR send. The first tests seem ok. Once this all is through, I would close the pull request and end the work on this firmware version. (https://github.com/arduino/mkrwan1300-fw/pull/35)

@sslupsky @giulcioffi Any suggestions before we close 1.2.4 and switch to a new firmware?

flhofer avatar Jun 21 '21 08:06 flhofer

Memory usage change @ 92f4b376b2920821998c7eee80d7ae0c7ffe8311

Board flash % RAM for global variables %
arduino:mbed_portenta:envie_m4 :small_red_triangle: 0 - +1136 0.0 - +0.11 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 :small_red_triangle: 0 - +1752 0.0 - +0.22 :small_red_triangle: 0 - +8 0.0 - 0.0
arduino:samd:mkrwan1300 :small_red_triangle: 0 - +1680 0.0 - +0.64 :small_red_triangle: 0 - +4 0.0 - +0.01
arduino:samd:mkrwan1310 :small_red_triangle: 0 - +1672 0.0 - +0.64 :small_red_triangle: 0 - +4 0.0 - +0.01
Click for full report table
Board examples/DumbModemLoraSender
flash		 % examples/DumbModemLoraSender
RAM for global variables		 % examples/FirstConfiguration
flash		 % examples/FirstConfiguration
RAM for global variables		 % examples/LoraSendAndReceive
flash		 % examples/LoraSendAndReceive
RAM for global variables		 % examples/FWUpdaterBridge
flash		 % examples/FWUpdaterBridge
RAM for global variables		 % examples/MKRWANFWUpdate_standalone
flash		 % examples/MKRWANFWUpdate_standalone
RAM for global variables		 %
arduino:mbed_portenta:envie_m4 0 0.0 0 0.0 1000 0.1 0 0.0 1136 0.11 0 0.0
arduino:mbed_portenta:envie_m7 0 0.0 0 0.0 1064 0.14 8 0.0 1136 0.14 8 0.0 0 0.0 0 0.0 1752 0.22 0 0.0
arduino:samd:mkrwan1300 0 0.0 0 0.0 1028 0.39 4 0.01 1144 0.44 4 0.01 0 0.0 0 0.0 1680 0.64 0 0.0
arduino:samd:mkrwan1310 0 0.0 0 0.0 1028 0.39 4 0.01 1148 0.44 4 0.01 0 0.0 0 0.0 1672 0.64 0 0.0
Click for full report CSV 
Board,examples/DumbModemLoraSender<br>flash,%,examples/DumbModemLoraSender<br>RAM for global variables,%,examples/FirstConfiguration<br>flash,%,examples/FirstConfiguration<br>RAM for global variables,%,examples/LoraSendAndReceive<br>flash,%,examples/LoraSendAndReceive<br>RAM for global variables,%,examples/FWUpdaterBridge<br>flash,%,examples/FWUpdaterBridge<br>RAM for global variables,%,examples/MKRWANFWUpdate_standalone<br>flash,%,examples/MKRWANFWUpdate_standalone<br>RAM for global variables,%
arduino:mbed_portenta:envie_m4,0,0.0,0,0.0,1000,0.1,0,0.0,1136,0.11,0,0.0
arduino:mbed_portenta:envie_m7,0,0.0,0,0.0,1064,0.14,8,0.0,1136,0.14,8,0.0,0,0.0,0,0.0,1752,0.22,0,0.0
arduino:samd:mkrwan1300,0,0.0,0,0.0,1028,0.39,4,0.01,1144,0.44,4,0.01,0,0.0,0,0.0,1680,0.64,0,0.0
arduino:samd:mkrwan1310,0,0.0,0,0.0,1028,0.39,4,0.01,1148,0.44,4,0.01,0,0.0,0,0.0,1672,0.64,0,0.0

github-actions[bot] avatar Jun 21 '21 16:06 github-actions[bot]

Memory usage change @ 7be70adcdfcaf1170e03fd9324d6ebaf3daf1229

Board flash % RAM for global variables %
arduino:mbed_portenta:envie_m4 :small_red_triangle: 0 - +1136 0.0 - +0.11 :green_heart: -8 - 0 -0.0 - 0.0
arduino:mbed_portenta:envie_m7 :small_red_triangle: 0 - +1752 0.0 - +0.22 :green_heart: -8 - 0 -0.0 - 0.0
arduino:samd:mkrwan1300 :small_red_triangle: 0 - +1672 0.0 - +0.64 :green_heart: -8 - 0 -0.02 - 0.0
arduino:samd:mkrwan1310 :small_red_triangle: 0 - +1664 0.0 - +0.63 :green_heart: -8 - 0 -0.02 - 0.0
Click for full report table
Board examples/DumbModemLoraSender
flash		 % examples/DumbModemLoraSender
RAM for global variables		 % examples/FirstConfiguration
flash		 % examples/FirstConfiguration
RAM for global variables		 % examples/LoraSendAndReceive
flash		 % examples/LoraSendAndReceive
RAM for global variables		 % examples/FWUpdaterBridge
flash		 % examples/FWUpdaterBridge
RAM for global variables		 % examples/MKRWANFWUpdate_standalone
flash		 % examples/MKRWANFWUpdate_standalone
RAM for global variables		 %
arduino:mbed_portenta:envie_m4 0 0.0 0 0.0 1000 0.1 -8 -0.0 1136 0.11 -8 -0.0
arduino:mbed_portenta:envie_m7 0 0.0 0 0.0 1064 0.14 -8 -0.0 1136 0.14 -8 -0.0 0 0.0 0 0.0 1752 0.22 0 0.0
arduino:samd:mkrwan1300 0 0.0 0 0.0 1028 0.39 -8 -0.02 1132 0.43 -8 -0.02 0 0.0 0 0.0 1672 0.64 0 0.0
arduino:samd:mkrwan1310 0 0.0 0 0.0 1028 0.39 -8 -0.02 1136 0.43 -8 -0.02 0 0.0 0 0.0 1664 0.63 0 0.0
Click for full report CSV 
Board,examples/DumbModemLoraSender<br>flash,%,examples/DumbModemLoraSender<br>RAM for global variables,%,examples/FirstConfiguration<br>flash,%,examples/FirstConfiguration<br>RAM for global variables,%,examples/LoraSendAndReceive<br>flash,%,examples/LoraSendAndReceive<br>RAM for global variables,%,examples/FWUpdaterBridge<br>flash,%,examples/FWUpdaterBridge<br>RAM for global variables,%,examples/MKRWANFWUpdate_standalone<br>flash,%,examples/MKRWANFWUpdate_standalone<br>RAM for global variables,%
arduino:mbed_portenta:envie_m4,0,0.0,0,0.0,1000,0.1,-8,-0.0,1136,0.11,-8,-0.0
arduino:mbed_portenta:envie_m7,0,0.0,0,0.0,1064,0.14,-8,-0.0,1136,0.14,-8,-0.0,0,0.0,0,0.0,1752,0.22,0,0.0
arduino:samd:mkrwan1300,0,0.0,0,0.0,1028,0.39,-8,-0.02,1132,0.43,-8,-0.02,0,0.0,0,0.0,1672,0.64,0,0.0
arduino:samd:mkrwan1310,0,0.0,0,0.0,1028,0.39,-8,-0.02,1136,0.43,-8,-0.02,0,0.0,0,0.0,1664,0.63,0,0.0

github-actions[bot] avatar Jun 24 '21 07:06 github-actions[bot]

Memory usage change @ fa55962803d0590be1ceccd281a53b2a39fae36c

Board flash % RAM for global variables %
arduino:mbed_portenta:envie_m4 :small_red_triangle: 0 - +1136 0.0 - +0.11 :green_heart: -8 - 0 -0.0 - 0.0
arduino:mbed_portenta:envie_m7 :small_red_triangle: 0 - +1752 0.0 - +0.22 :green_heart: -8 - 0 -0.0 - 0.0
arduino:samd:mkrwan1300 :small_red_triangle: 0 - +1672 0.0 - +0.64 :green_heart: -8 - 0 -0.02 - 0.0
arduino:samd:mkrwan1310 :small_red_triangle: 0 - +1664 0.0 - +0.63 :green_heart: -8 - 0 -0.02 - 0.0
Click for full report table
Board examples/DumbModemLoraSender
flash		 % examples/DumbModemLoraSender
RAM for global variables		 % examples/FirstConfiguration
flash		 % examples/FirstConfiguration
RAM for global variables		 % examples/LoraSendAndReceive
flash		 % examples/LoraSendAndReceive
RAM for global variables		 % examples/FWUpdaterBridge
flash		 % examples/FWUpdaterBridge
RAM for global variables		 % examples/MKRWANFWUpdate_standalone
flash		 % examples/MKRWANFWUpdate_standalone
RAM for global variables		 %
arduino:mbed_portenta:envie_m4 0 0.0 0 0.0 1000 0.1 -8 -0.0 1136 0.11 -8 -0.0
arduino:mbed_portenta:envie_m7 0 0.0 0 0.0 1064 0.14 -8 -0.0 1136 0.14 -8 -0.0 0 0.0 0 0.0 1752 0.22 0 0.0
arduino:samd:mkrwan1300 0 0.0 0 0.0 1028 0.39 -8 -0.02 1132 0.43 -8 -0.02 0 0.0 0 0.0 1672 0.64 0 0.0
arduino:samd:mkrwan1310 0 0.0 0 0.0 1028 0.39 -8 -0.02 1136 0.43 -8 -0.02 0 0.0 0 0.0 1664 0.63 0 0.0
Click for full report CSV 
Board,examples/DumbModemLoraSender<br>flash,%,examples/DumbModemLoraSender<br>RAM for global variables,%,examples/FirstConfiguration<br>flash,%,examples/FirstConfiguration<br>RAM for global variables,%,examples/LoraSendAndReceive<br>flash,%,examples/LoraSendAndReceive<br>RAM for global variables,%,examples/FWUpdaterBridge<br>flash,%,examples/FWUpdaterBridge<br>RAM for global variables,%,examples/MKRWANFWUpdate_standalone<br>flash,%,examples/MKRWANFWUpdate_standalone<br>RAM for global variables,%
arduino:mbed_portenta:envie_m4,0,0.0,0,0.0,1000,0.1,-8,-0.0,1136,0.11,-8,-0.0
arduino:mbed_portenta:envie_m7,0,0.0,0,0.0,1064,0.14,-8,-0.0,1136,0.14,-8,-0.0,0,0.0,0,0.0,1752,0.22,0,0.0
arduino:samd:mkrwan1300,0,0.0,0,0.0,1028,0.39,-8,-0.02,1132,0.43,-8,-0.02,0,0.0,0,0.0,1672,0.64,0,0.0
arduino:samd:mkrwan1310,0,0.0,0,0.0,1028,0.39,-8,-0.02,1136,0.43,-8,-0.02,0,0.0,0,0.0,1664,0.63,0,0.0

github-actions[bot] avatar Jul 10 '21 20:07 github-actions[bot]

Memory usage change @ ca0bd8bc5d6c3a791282a2dd6669af756dae3fbe

Board flash % RAM for global variables %
arduino:mbed_portenta:envie_m4 :small_red_triangle: 0 - +1272 0.0 - +0.12 :green_heart: -8 - 0 -0.0 - 0.0
arduino:mbed_portenta:envie_m7 :small_red_triangle: 0 - +1688 0.0 - +0.21 :green_heart: -8 - 0 -0.0 - 0.0
arduino:samd:mkrwan1300 :small_red_triangle: 0 - +17156 0.0 - +6.54 :green_heart: -8 - 0 -0.02 - 0.0
arduino:samd:mkrwan1310 :small_red_triangle: 0 - +17156 0.0 - +6.54 :green_heart: -8 - 0 -0.02 - 0.0
Click for full report table
Board examples/DumbModemLoraSender
flash		 % examples/DumbModemLoraSender
RAM for global variables		 % examples/FirstConfiguration
flash		 % examples/FirstConfiguration
RAM for global variables		 % examples/LoraSendAndReceive
flash		 % examples/LoraSendAndReceive
RAM for global variables		 % examples/FWUpdaterBridge
flash		 % examples/FWUpdaterBridge
RAM for global variables		 % examples/MKRWANFWUpdate_standalone
flash		 % examples/MKRWANFWUpdate_standalone
RAM for global variables		 %
arduino:mbed_portenta:envie_m4 0 0.0 0 0.0 1200 0.11 -8 -0.0 1272 0.12 -8 -0.0
arduino:mbed_portenta:envie_m7 0 0.0 0 0.0 1192 0.15 -8 -0.0 1328 0.17 -8 -0.0 0 0.0 0 0.0 1688 0.21 0 0.0
arduino:samd:mkrwan1300 0 0.0 0 0.0 17044 6.5 -8 -0.02 17156 6.54 -8 -0.02 0 0.0 0 0.0 1680 0.64 0 0.0
arduino:samd:mkrwan1310 0 0.0 0 0.0 17044 6.5 -8 -0.02 17156 6.54 -8 -0.02 0 0.0 0 0.0 1672 0.64 0 0.0
Click for full report CSV 
Board,examples/DumbModemLoraSender<br>flash,%,examples/DumbModemLoraSender<br>RAM for global variables,%,examples/FirstConfiguration<br>flash,%,examples/FirstConfiguration<br>RAM for global variables,%,examples/LoraSendAndReceive<br>flash,%,examples/LoraSendAndReceive<br>RAM for global variables,%,examples/FWUpdaterBridge<br>flash,%,examples/FWUpdaterBridge<br>RAM for global variables,%,examples/MKRWANFWUpdate_standalone<br>flash,%,examples/MKRWANFWUpdate_standalone<br>RAM for global variables,%
arduino:mbed_portenta:envie_m4,0,0.0,0,0.0,1200,0.11,-8,-0.0,1272,0.12,-8,-0.0
arduino:mbed_portenta:envie_m7,0,0.0,0,0.0,1192,0.15,-8,-0.0,1328,0.17,-8,-0.0,0,0.0,0,0.0,1688,0.21,0,0.0
arduino:samd:mkrwan1300,0,0.0,0,0.0,17044,6.5,-8,-0.02,17156,6.54,-8,-0.02,0,0.0,0,0.0,1680,0.64,0,0.0
arduino:samd:mkrwan1310,0,0.0,0,0.0,17044,6.5,-8,-0.02,17156,6.54,-8,-0.02,0,0.0,0,0.0,1672,0.64,0,0.0

github-actions[bot] avatar Jul 25 '21 15:07 github-actions[bot]

Memory usage change @ 7eae6c39ae324daf73f55a3be2dd79ea59b3c674

Board flash % RAM for global variables %
arduino:mbed_portenta:envie_m4 :small_red_triangle: 0 - +1216 0.0 - +0.12 :green_heart: -8 - 0 -0.0 - 0.0
arduino:mbed_portenta:envie_m7 :small_red_triangle: 0 - +1920 0.0 - +0.24 :green_heart: -8 - 0 -0.0 - 0.0
arduino:samd:mkrwan1300 :small_red_triangle: 0 - +1864 0.0 - +0.71 :green_heart: -8 - 0 -0.02 - 0.0
arduino:samd:mkrwan1310 :small_red_triangle: 0 - +1856 0.0 - +0.71 :green_heart: -8 - 0 -0.02 - 0.0
Click for full report table
Board examples/DumbModemLoraSender
flash		 % examples/DumbModemLoraSender
RAM for global variables		 % examples/FirstConfiguration
flash		 % examples/FirstConfiguration
RAM for global variables		 % examples/LoraSendAndReceive
flash		 % examples/LoraSendAndReceive
RAM for global variables		 % examples/FWUpdaterBridge
flash		 % examples/FWUpdaterBridge
RAM for global variables		 % examples/MKRWANFWUpdate_standalone
flash		 % examples/MKRWANFWUpdate_standalone
RAM for global variables		 %
arduino:mbed_portenta:envie_m4 0 0.0 0 0.0 1144 0.11 -8 -0.0 1216 0.12 -8 -0.0
arduino:mbed_portenta:envie_m7 0 0.0 0 0.0 1144 0.15 -8 -0.0 1280 0.16 -8 -0.0 0 0.0 0 0.0 1920 0.24 0 0.0
arduino:samd:mkrwan1300 0 0.0 0 0.0 1168 0.45 -8 -0.02 1272 0.49 -8 -0.02 0 0.0 0 0.0 1864 0.71 0 0.0
arduino:samd:mkrwan1310 0 0.0 0 0.0 1168 0.45 -8 -0.02 1276 0.49 -8 -0.02 0 0.0 0 0.0 1856 0.71 0 0.0
Click for full report CSV 
Board,examples/DumbModemLoraSender<br>flash,%,examples/DumbModemLoraSender<br>RAM for global variables,%,examples/FirstConfiguration<br>flash,%,examples/FirstConfiguration<br>RAM for global variables,%,examples/LoraSendAndReceive<br>flash,%,examples/LoraSendAndReceive<br>RAM for global variables,%,examples/FWUpdaterBridge<br>flash,%,examples/FWUpdaterBridge<br>RAM for global variables,%,examples/MKRWANFWUpdate_standalone<br>flash,%,examples/MKRWANFWUpdate_standalone<br>RAM for global variables,%
arduino:mbed_portenta:envie_m4,0,0.0,0,0.0,1144,0.11,-8,-0.0,1216,0.12,-8,-0.0
arduino:mbed_portenta:envie_m7,0,0.0,0,0.0,1144,0.15,-8,-0.0,1280,0.16,-8,-0.0,0,0.0,0,0.0,1920,0.24,0,0.0
arduino:samd:mkrwan1300,0,0.0,0,0.0,1168,0.45,-8,-0.02,1272,0.49,-8,-0.02,0,0.0,0,0.0,1864,0.71,0,0.0
arduino:samd:mkrwan1310,0,0.0,0,0.0,1168,0.45,-8,-0.02,1276,0.49,-8,-0.02,0,0.0,0,0.0,1856,0.71,0,0.0

github-actions[bot] avatar Aug 24 '21 13:08 github-actions[bot]

Finished tests, think I'm done here. Anything else?

flhofer avatar Aug 24 '21 13:08 flhofer

Memory usage change @ 430e02c352ac51eb8fd54daff13a91f09b41f7c1

Board flash % RAM for global variables %
arduino:mbed_portenta:envie_m4 :small_red_triangle: 0 - +1280 0.0 - +0.12 :green_heart: -8 - 0 -0.0 - 0.0
arduino:mbed_portenta:envie_m7 :small_red_triangle: 0 - +1912 0.0 - +0.24 :green_heart: -8 - 0 -0.0 - 0.0
arduino:samd:mkrwan1300 :small_red_triangle: 0 - +1856 0.0 - +0.71 :green_heart: -8 - 0 -0.02 - 0.0
arduino:samd:mkrwan1310 :small_red_triangle: 0 - +1856 0.0 - +0.71 :green_heart: -8 - 0 -0.02 - 0.0
Click for full report table
Board examples/DumbModemLoraSender
flash		 % examples/DumbModemLoraSender
RAM for global variables		 % examples/FirstConfiguration
flash		 % examples/FirstConfiguration
RAM for global variables		 % examples/LoraSendAndReceive
flash		 % examples/LoraSendAndReceive
RAM for global variables		 % examples/FWUpdaterBridge
flash		 % examples/FWUpdaterBridge
RAM for global variables		 % examples/MKRWANFWUpdate_standalone
flash		 % examples/MKRWANFWUpdate_standalone
RAM for global variables		 %
arduino:mbed_portenta:envie_m4 0 0.0 0 0.0 1144 0.11 -8 -0.0 1280 0.12 -8 -0.0
arduino:mbed_portenta:envie_m7 0 0.0 0 0.0 1208 0.15 -8 -0.0 1280 0.16 -8 -0.0 0 0.0 0 0.0 1912 0.24 0 0.0
arduino:samd:mkrwan1300 0 0.0 0 0.0 1168 0.45 -8 -0.02 1272 0.49 -8 -0.02 0 0.0 0 0.0 1856 0.71 0 0.0
arduino:samd:mkrwan1310 0 0.0 0 0.0 1168 0.45 -8 -0.02 1276 0.49 -8 -0.02 0 0.0 0 0.0 1856 0.71 0 0.0
Click for full report CSV 
Board,examples/DumbModemLoraSender<br>flash,%,examples/DumbModemLoraSender<br>RAM for global variables,%,examples/FirstConfiguration<br>flash,%,examples/FirstConfiguration<br>RAM for global variables,%,examples/LoraSendAndReceive<br>flash,%,examples/LoraSendAndReceive<br>RAM for global variables,%,examples/FWUpdaterBridge<br>flash,%,examples/FWUpdaterBridge<br>RAM for global variables,%,examples/MKRWANFWUpdate_standalone<br>flash,%,examples/MKRWANFWUpdate_standalone<br>RAM for global variables,%
arduino:mbed_portenta:envie_m4,0,0.0,0,0.0,1144,0.11,-8,-0.0,1280,0.12,-8,-0.0
arduino:mbed_portenta:envie_m7,0,0.0,0,0.0,1208,0.15,-8,-0.0,1280,0.16,-8,-0.0,0,0.0,0,0.0,1912,0.24,0,0.0
arduino:samd:mkrwan1300,0,0.0,0,0.0,1168,0.45,-8,-0.02,1272,0.49,-8,-0.02,0,0.0,0,0.0,1856,0.71,0,0.0
arduino:samd:mkrwan1310,0,0.0,0,0.0,1168,0.45,-8,-0.02,1276,0.49,-8,-0.02,0,0.0,0,0.0,1856,0.71,0,0.0

github-actions[bot] avatar Oct 29 '21 08:10 github-actions[bot]

Memory usage change @ 05491ef37d701a32e24b2c46d42e04715d0458ec

Board flash % RAM for global variables %
arduino:mbed_portenta:envie_m4 :small_red_triangle: 0 - +1280 0.0 - +0.12 :green_heart: -8 - 0 -0.0 - 0.0
arduino:mbed_portenta:envie_m7 :small_red_triangle: 0 - +1912 0.0 - +0.24 :green_heart: -8 - 0 -0.0 - 0.0
arduino:samd:mkrwan1300 :small_red_triangle: 0 - +1872 0.0 - +0.71 :green_heart: -8 - 0 -0.02 - 0.0
arduino:samd:mkrwan1310 :small_red_triangle: 0 - +1872 0.0 - +0.71 :green_heart: -8 - 0 -0.02 - 0.0
Click for full report table
Board examples/DumbModemLoraSender
flash		 % examples/DumbModemLoraSender
RAM for global variables		 % examples/FirstConfiguration
flash		 % examples/FirstConfiguration
RAM for global variables		 % examples/LoraSendAndReceive
flash		 % examples/LoraSendAndReceive
RAM for global variables		 % examples/FWUpdaterBridge
flash		 % examples/FWUpdaterBridge
RAM for global variables		 % examples/MKRWANFWUpdate_standalone
flash		 % examples/MKRWANFWUpdate_standalone
RAM for global variables		 %
arduino:mbed_portenta:envie_m4 0 0.0 0 0.0 1144 0.11 -8 -0.0 1280 0.12 -8 -0.0
arduino:mbed_portenta:envie_m7 0 0.0 0 0.0 1208 0.15 -8 -0.0 1280 0.16 -8 -0.0 0 0.0 0 0.0 1912 0.24 0 0.0
arduino:samd:mkrwan1300 0 0.0 0 0.0 1184 0.45 -8 -0.02 1288 0.49 -8 -0.02 0 0.0 0 0.0 1872 0.71 0 0.0
arduino:samd:mkrwan1310 0 0.0 0 0.0 1184 0.45 -8 -0.02 1292 0.49 -8 -0.02 0 0.0 0 0.0 1872 0.71 0 0.0
Click for full report CSV 
Board,examples/DumbModemLoraSender<br>flash,%,examples/DumbModemLoraSender<br>RAM for global variables,%,examples/FirstConfiguration<br>flash,%,examples/FirstConfiguration<br>RAM for global variables,%,examples/LoraSendAndReceive<br>flash,%,examples/LoraSendAndReceive<br>RAM for global variables,%,examples/FWUpdaterBridge<br>flash,%,examples/FWUpdaterBridge<br>RAM for global variables,%,examples/MKRWANFWUpdate_standalone<br>flash,%,examples/MKRWANFWUpdate_standalone<br>RAM for global variables,%
arduino:mbed_portenta:envie_m4,0,0.0,0,0.0,1144,0.11,-8,-0.0,1280,0.12,-8,-0.0
arduino:mbed_portenta:envie_m7,0,0.0,0,0.0,1208,0.15,-8,-0.0,1280,0.16,-8,-0.0,0,0.0,0,0.0,1912,0.24,0,0.0
arduino:samd:mkrwan1300,0,0.0,0,0.0,1184,0.45,-8,-0.02,1288,0.49,-8,-0.02,0,0.0,0,0.0,1872,0.71,0,0.0
arduino:samd:mkrwan1310,0,0.0,0,0.0,1184,0.45,-8,-0.02,1292,0.49,-8,-0.02,0,0.0,0,0.0,1872,0.71,0,0.0

github-actions[bot] avatar Dec 05 '21 13:12 github-actions[bot]

@sslupsky anyone reviewing this? would solve a lot of open issues 😃

flhofer avatar Jan 31 '22 08:01 flhofer

@sslupsky anyone reviewing this? would solve a lot of open issues 😃

Agree - looking forward to this being merged 👍

nextstep79 avatar Mar 05 '22 09:03 nextstep79

guys? @giulcioffi @sslupsky @sebromero

flhofer avatar Apr 11 '22 07:04 flhofer

guys? @giulcioffi @sslupsky @sebromero

Ping?

flhofer avatar May 19 '22 09:05 flhofer

This PR fixes a lot of issues with the current master (v1.2.3), but it unfortunately seems to have introduced another.

I'm not able to send binary data, or at least send it correctly (it works on master). For example, sending a package with 3 bytes [0,1,255] (0x00, 0x01, 0xFF) returns -7 (LORA_ERROR_RX). I have tried using modem.write() and modem.print(). modem.write() only works with single char/byte/int etc. and not for arrays. Trying to call modem.write() more than once give the same error -7. The only way i was able to send the binary data was with modem.print() and the formanBin flag set to true, but the formatting doubles the package size. Looking into the modemSend() code I have found the issue, every HEX (4 bits) is using 8 bits (1 byte) of TX buffer. The endPackage() returns the correct number of bytes, but the received package in the network server shows the double amount of bytes. I looks like this is a firmware bug, since I have not been able to fix this in the MKRWAN.h code.

For my applications this is a big deal since I need to send as much data as possible as often as possible. I would love to use this branch, but until this is fixed I'm forced to use master with the issues it has.

Larshand92 avatar Sep 16 '22 07:09 Larshand92

@Larshand92 Hi Lars. Thanks for the heads up. Are you using the matching firmware version or the 1.2.3 default? I had to fix a lot of stuff in the firmware as well to make binary send work. Before the changes, binary did not work at all.

This could explain your data doubling at the network server. You have double the data because to tx binary we have to translate bytes to ascii, i.e., we take the hex value and translate it to two ascii chars, to send it over the serial terminal to the lora modem. The modem firmware has then to translate it back. It seems that in your case the firmware is not doing that.

Can you follow up on this? Thanks.

flhofer avatar Oct 21 '22 15:10 flhofer