Keyboard icon indicating copy to clipboard operation
Keyboard copied to clipboard

Created KeyboardandMousecontrol.ino

Open Arsh0508 opened this issue 5 years ago • 4 comments

This code would be really helpful for new users and so it'll be great if this code is present in the library itself

Arsh0508 avatar Mar 15 '20 11:03 Arsh0508

As I brought up in https://github.com/arduino-libraries/Mouse/pull/13#issuecomment-598643770:

One thing to note is that this example already comes bundled with the Arduino IDE (and Arduino Web Editor) under File > Examples > 09.USB > KeyboardAndMouseControl.

It does make sense to bundle the examples with the library since the IDE bundled examples are not available to arduino-cli and Arduino Pro IDE users. I don't like the idea of having duplicate code to maintain, but it also could be problematic to remove the built-in sketches since there are likely tutorials that point people to that menu path. I suppose we could replace the content of the built in sketches with a comment like:

// This example has been moved to File > Examples > Keyboard > KeyboardLogout

(should be adapted to make sense for Arduino Web Editor users also)

per1234 avatar Mar 16 '20 04:03 per1234

@per1234 thank you so much for your valuable suggestions sir, will get right onto it and make the needful changes.

Arsh0508 avatar Mar 17 '20 06:03 Arsh0508

@per1234 I've done the requested changes and would be grateful if you can review them.

Arsh0508 avatar Mar 17 '20 09:03 Arsh0508

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Apr 09 '21 13:04 CLAassistant