API refactor
Proposal for API refactor
I strongly suggest to have just the object MachineControl for all the methods and align all the APIs to the one I proposed above. cc @pnndra @navalog @manchoz
Some observations:
MachineControl.begin()to bring everything in a failsafe position should be implemented but cannot be made compulsory.AnalogInrefactor looks ok, we just need to document it extensively (if there are no user tunables)AnalogOutreally depends on the user, so I'd merge the original sketch and the proposal like
analog_out.write(0, 3.3);
analog_out.write(1, 4.1);
analog_out.write(2, 5);
analog_out.write(3, 10.3);
- DigitalOut: is
setLatchthe only way to use that channels?
Apart from this, I'd leave the names as written on the silk (so digital_outputs, although horrible, is better than DigitalOut)
Then, I have no clue about what kind of people will use this library, their level of expertise and their experience with Arduino (I think the latter won't be that high). Can we ask some of the early customers how they are feeling with the current API organization?
we should ask to Rinaldi and all the customers whom Giacomo provided a PCM
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.