ArduinoMDNS icon indicating copy to clipboard operation
ArduinoMDNS copied to clipboard

Please release version and tag

Open rzr opened this issue 5 years ago • 3 comments

I am looking a way to to pin my dependencies, would this be possible to have tags in this repo ?

Eventually aligned the arduino sdk ones

rzr avatar Jul 11 '19 09:07 rzr

@rzr @per1234 Can you elaborate what you are trying to say?

thekunalsaini avatar Mar 20 '20 08:03 thekunalsaini

having tags in git repo would help because my project uses makefiles to pull libs using git clone.

rzr avatar Mar 20 '20 10:03 rzr

I tried creating a v1.0.0 release and tag on my fork. You can have a look at it here

I read through a few standard rules and naming conventions before giving it a base numbers. Few resources if someone wants to follow up-

  1. https://semver.org/
  2. https://softwareengineering.stackexchange.com/questions/345006/why-popular-repositories-use-release-version-as-a-release-title-in-github
  3. https://rollout.io/blog/best-practices-when-versioning-a-release/

Now though I've added the release and tag to my fork, it turn out that it can't be included in a pull request and hence I can not create a PR for this. More on this here.

" A pull request does not include tags. A pull request is only a pointer to a thread of commits (a branch) in your repository that you're proposing another repository to merge."

"The best and only method really becomes to ask the maintainer to issue a release for his code by tagging if that's the way they do it but that is to their discretion!"

So, @TrippyLighting or any maintainer for this, kindly look into my release on fork, preferably add appropriate release description and make changes.

MisterAwesome23 avatar Apr 12 '20 20:04 MisterAwesome23

Released! Will be available in the library manager shortly.

alranel avatar Oct 31 '23 14:10 alranel