wasabi icon indicating copy to clipboard operation
wasabi copied to clipboard
verified publisher icon arduano

Remove KDMAPI and MIDI device options for unsupported OSes

Open MyBlackMIDIScore opened this issue 9 months ago • 2 comments

Fixes #89

Idk if there is a better way to do this. I feel likeI have added too many of those cfg flags but I couldn't think of another way rn

MyBlackMIDIScore avatar Mar 25 '25 22:03 MyBlackMIDIScore

KDMAPI can work under BSD due to XSynth working under it, allowing for KDMAPI use with XSynth. It might also be possible to get OMv2 working under BSD, but I'm not sure.

Kaydax avatar Mar 25 '25 22:03 Kaydax

I mean using XSynth through KDMAPI in Wasabi is pretty stupid since it is built in... But if there are plans to support FBSD in OMv2 I guess we can modify the kdmapi-rs package to support that. Although even then there will be other OSes that will fail to build KDMAPI if we just add support for FBSD, plus the restriction is needed for MIDI devices since midir doesn't support anything else except win, mac and linux

MyBlackMIDIScore avatar Mar 25 '25 23:03 MyBlackMIDIScore

Personally I'd abstract the system into its own module to reduce the use of cfg as much as possible, but I don't think any of us have the energy for that lol

arduano avatar May 28 '25 09:05 arduano

Personally I'd abstract the system into its own module to reduce the use of cfg as much as possible, but I don't think any of us have the energy for that lol

It is probably a better approach but I don't have time to do that right now lol I'll merge this now and I'll add it to my todo list to clean it up

MyBlackMIDIScore avatar May 31 '25 09:05 MyBlackMIDIScore