Philip Ardery

Results 175 comments of Philip Ardery

This is a good reminder that I still don't understand encoding handling as well as I should. Thanks for looking into it! Sent from a phone > On Feb 17,...

is the `soup` moniker derived from the beautifulsoup package name? It seems like you use `self.soup` where we traditionally might use `self.html`. It doesn't bother me, I just want to...

good idea @mlissner. for the intial setting of `self.html/soup`, that usually happens in download. But we also tend to just call download once. So if `_get_soup` is or may be...

Thanks @audiodude. @mlissner, care to chime in?

can we not just let `_download` retain its function of making the initial request, to get the landing page, and then create some new function (`_download_sub_page` or something) that handles...

this looks clean to me. My only suggestion is perhaps more commenting to explain some of the more cryptic PDF looping stuff. Let's hope they have some consistent/automated way of...

i have no opinions on the code here, just wanted to chime in to provide my $0.02 that [youtube-dl](https://github.com/rg3/youtube-dl/) is an awesome, highly active project, and a great tool for...

"the webmasters are the voodoo providers" Lol, too true. Reminds me of colo and makes me shudder. As for ytdl extracting audio, it doesn't really "extract" audio per se, at...

yep, it's quite intensive on the processor