Philip Ardery comments

Results 206 comments of


                                            Philip Ardery

QueryBuilder->getQuery->getResult() does not work properly when $indexBy is provided to ->from()

Sounds about right @arnaud-lb. If this should be an enhancement request, it would be really cool to have this support added.

QueryBuilder->getQuery->getResult() does not work properly when $indexBy is provided to ->from()

any luck here?

6 to 7 upgrade documentation does not include deprecation of Task->setPrivate()

based on the updated docs, I suspect the new usage is `->hidden()`: https://deployer.org/docs/7.x/tasks#hidden I will leave this open as a reminder to update the migration docs.

MySQL table engine not changed

hows this going? I am still seeing a broken `up()` generation due to this bug

MySQL table engine not changed

I can try to take a closer look when I have more time, but would be awesome if someone who is more familiar with the code base could chime in

MySQL table engine not changed

For what it is worth, my issue with collation junk populating my `down()` function was somehow resolved for me somewhere in the process of upgrading from Symfony 4.4 to 5.4,...

Remove `stable` package in favor of native stable sort

+1 on merge, please :)

Remove `stable` package in favor of native stable sort

That's kind but less than ideal. Is it possible this package has been abandoned?

Add support for pnpm and Yarn PnP

Thanks for doing all of this @Kocal, looks like you're almost there!

Sortable - ability to reset children to positions pre-sort?

+1 for `Sortable#revert`, that would be awesome. Thanks for the amazing tool! @tsov, is there an issue of that feature that I and other can track so we are notified...