Philip Ardery comments

Results 206 comments of


                                            Philip Ardery

any way to support typing for $request->request->get()?

If I find some time I will look into that and comment back here.

any way to support typing for $request->request->get()?

well, that was easier than I thought: https://github.com/arderyp/phpstan-issue-262 @ondrejmirtes

any way to support typing for $request->request->get()?

should we open this back up @ondrejmirtes?

any way to support typing for $request->request->get()?

``` $ composer require symfony/http-foundation Info from https://repo.packagist.org: #StandWithUkraine ./composer.json has been updated Running composer update symfony/http-foundation Loading composer repositories with package information Info from https://repo.packagist.org: #StandWithUkraine Updating dependencies Nothing...

any way to support typing for $request->request->get()?

Hey @ondrejmirtes, I believe part of the confusions here is stemming from the fact that you were expecting an object of type `Symfony\Component\HttpFoundation\InputBag`, but it looks like that wasn't introduced...

any way to support typing for $request->request->get()?

I plan to this summer, but it's a major version upgrade, not a simple composer update and call it a day. Glad the newer versions play more nicely with typing...

any way to support typing for $request->request->get()?

Good question @TomBrunner I haven't heard back from maintainers on my suggested improvements for typed getters on the `*Bag` objects: https://github.com/symfony/symfony/issues/45775

QueryBuilder->getQuery->getResult() does not work properly when $indexBy is provided to ->from()

I've gotten around the error with the following stub, but not sure if its the correct approach: ```

QueryBuilder->getQuery->getResult() does not work properly when $indexBy is provided to ->from()

Yeah, I'm using the following: ``` #phpstan.neon doctrine: objectManagerLoader: tests/object-manager.php ``` ``` #tests/object-manager.php

QueryBuilder->getQuery->getResult() does not work properly when $indexBy is provided to ->from()

*fixed typo in original post*