install location of icudtl.dat
icudtl.dat is not a system library, is generally unique to an application, and really shouldn't be installed in /usr/lib/.
In meta-flutter I install icudtl.dat to /usr/share/flutter. This is shared between users, and specific to flutter.
With this commit you can put it inside bundle together with engine so it no longer requires system installation and allows to tie it to application.
I'm not sure it is wise to do anything else as this file probably compatible only with particular flutter versions
@DoumanAsh true, I think bundling it with the app is even better, but since most people do install engine system-wide, we might as well install the icudtl system-wide as well.
@jwinarske Loading it from /usr/share/flutter is fine. I didn't really think about it too much when I put it inside /usr/lib. I'll prepare a PR and change the engine-binaries installer so it installs to /usr/share/flutter.
@DoumanAsh Yes I started using the bundle override approach here.
If the override path is available, it will use it otherwise defaults to the system locations.
It supports two use case scenarios:
- local bundle override - update/debug app independent of system version
- system default - for baseline OS build, and LTS SDK
For this issue the point is that icuctl.dat should be in /usr/share/flutter instead of /usr/lib.
I'm trying to consolidate the need for this patch: https://github.com/meta-flutter/meta-flutter/blob/kirkstone/recipes-graphics/flutter-pi/files/0001-path-updates.patch
Makes sense, my plan was to make it look inside the app dir first, then inside /usr/share/flutter and then inside /usr/lib.
fixed by https://github.com/ardera/flutter-pi/pull/290