chrome-better-bookmark icon indicating copy to clipboard operation
chrome-better-bookmark copied to clipboard

version for Firefox

Open lpslp opened this issue 4 years ago • 5 comments

hi - is there a version of you great addon for Firefox?

lpslp avatar Jun 03 '20 16:06 lpslp

@lpslp This repo didn't update for many years, so I have rewritten it in React, check this https://github.com/fffx/quick-bookmark. I didn't release a firefox version for now, because I haven't decided on default key binding, as cmd+B is a firefox shortcut.

The chrome version is here https://chrome.google.com/webstore/detail/quick-bookmark/bbjekmkfbdemdbfkckbakmmiceppjkdc/related

fffx avatar Dec 28 '20 04:12 fffx

@fffx it's nice to see that you're building on top of my work, but please note that this extension was released under MIT license, according to which you're required to keep my credentials in authors fields (in, LICENSE.md, package.json, and manifest.json)

ardcore avatar Jan 05 '21 16:01 ardcore

@fffx it's nice to see that you're building on top of my work, but please note that this extension was released under MIT license, according to which you're required to keep my credentials in authors fields (in, LICENSE.md, package.json, and manifest.json)

thanks for your work, my project structure is based on web-extension-starter, and then I rewrite it by looking at your project。so the liscense is also copy from web-extension-starter。I'm sorry for not puting your notice in the lisence file. I will do it in a few days. But why I should put your liscense notice in package.json, manifest.json, since your project even don't have a package.json file? And Where do I put mutiple author in package.json or manifest.json?

fffx avatar Jan 06 '21 08:01 fffx

@fffx thanks for understanding. I think putting my name back into the LICENSE.md file and creating a separate file called AUTHORS.md listing us both (in separate lines) should be enough. :)

ardcore avatar Jan 06 '21 16:01 ardcore

FYI: added https://github.com/fffx/quick-bookmark/blob/master/AUTHORS.md updated: https://github.com/fffx/quick-bookmark/blob/master/LICENCE

fffx avatar Jan 07 '21 14:01 fffx