graphql-mesh icon indicating copy to clipboard operation
graphql-mesh copied to clipboard

@omnigraph/grpc is missing

Open presian-news opened this issue 1 year ago • 8 comments

Issue workflow progress

Progress of the issue based on the Contributor Workflow

Make sure to fork this template and run yarn generate in the terminal.

Please make sure Mesh package versions under package.json matches yours.

  • [x] 2. A failing test has been provided
  • [ ] 3. A local solution has been provided
  • [ ] 4. A pull request is pending review

Describe the bug

@omnigraph/grpc is a dependency of release 1.0.1 but does not exist on npm

To Reproduce Steps to reproduce the behavior:


$ yarn add @omnigraph/grpc
yarn add v1.22.22
[1/4] Resolving packages...
error Error: https://registry.yarnpkg.com/@omnigraph%2fgrpc: Not found

Expected behavior

the grpc dependency is resolved.

Environment:

  • OS: cos
  • @graphql-mesh/...: 1.0.1
  • NodeJS: 20

Additional context

presian-news avatar Sep 11 '24 11:09 presian-news

You should install it manually; https://the-guild.dev/graphql/mesh/v1/source-handlers/grpc

ardatan avatar Sep 11 '24 12:09 ardatan

Thanks for your reply! I can't find omnigraph/grpc on npm?

presian-news avatar Sep 11 '24 12:09 presian-news

any updates?

culttm avatar Sep 23 '24 07:09 culttm

@omnigraph/grpc is not in the npm registry, or you have no permission to fetch it. ?

mifrej avatar Oct 07 '24 09:10 mifrej

How am I supposed to proceed with recommended v1 without this package?

mifrej avatar Oct 07 '24 09:10 mifrej

@mifrej My team gave up on using this package. Great idea, but poor communication from the maintainer.

Sorry to hear that. Most of the maintainers were off or busy with other stuff, and specifically I was on a vacation. So I wasn't ignoring any of the messages here but just saw them. We just came back to work fully, and we are trying to catch up all the contributions made by the community. Other than that, usually we are trying to be responsive as much as we can as you can also see the activity in the repo. Maybe you could try to look at the code by yourself, and contribute to the project in a PR, then after we were back, this would have helped us on providing the solution in a shorter time by using your contribution.

Anyway, the actual issue is that package is missed during the v1 refactor while the implementation has been existed already in v0 inside @graphql-mesh/grpc. We will take care of that soon, and keep you updated. Unfortunately, I cannot give an ETA right now. But I'll write here when we start working on that (with a PR).

ardatan avatar Oct 16 '24 09:10 ardatan

Thank You for the update @ardatan. Good to hear you are back on the development cycle.

mifrej avatar Oct 16 '24 16:10 mifrej