graphql-mesh icon indicating copy to clipboard operation
graphql-mesh copied to clipboard

Published 20 hours ago • verified publisher icon ardatan

Format check in CI

Open enisdenjo opened this issue 3 months ago • 3 comments

#6748 was merged with a bunch of formatting issues (that I fixed later). Add a format check to the CI to prevent this.

enisdenjo avatar Mar 28 '24 18:03 enisdenjo

This needs to be fixed then https://github.com/ardatan/graphql-mesh/blob/708c184cb631cc125c295c64bb98f27e78ce7682/.github/workflows/tests.yml#L17

ardatan avatar Mar 28 '24 19:03 ardatan

hmm the lint run did exit with 1, but the ci passed still https://github.com/ardatan/graphql-mesh/actions/runs/8471226281/job/23211261474

enisdenjo avatar Mar 29 '24 11:03 enisdenjo

I reckon it's because of the continue-on-error in The Guild's lint workflow https://github.com/the-guild-org/shared-config/blob/0300346178e425c37c6f028959634499282d5700/.github/workflows/lint.yml#L55

enisdenjo avatar Mar 29 '24 11:03 enisdenjo