Arda TANRIKULU comments

Results 597 comments of


                                            Arda TANRIKULU

Peer dependency warnings from @graphql-tools/graphql-tag-pluck on @babel/core

I don't use PNPM or newer versions of Yarn. PRs are welcome to fix it.

Peer dependency warnings from @graphql-tools/graphql-tag-pluck on @babel/core

Closing this issue since peer dependency has bene added in the latest version.

Multiple directives not working in the sequence as defined in the graphql query

Could you share a reproduction on CodeSandbox? Thanks!

http executor should always throw GraphQLError upon non 2xx response

> If the issue is reasonable, I could help by opening a PR. Thanks for reporting the issue! We'd love to accept a PR with a failing test!

http executor should always throw GraphQLError upon non 2xx response

I think I misunderstood the issue in the beginning. I think you are missing the case that a response can have a valid result with `data` and/or `errors` with a...

http executor should always throw GraphQLError upon non 2xx response

The check for retry should check if it is greater than 0. You're right.

http executor should always throw GraphQLError upon non 2xx response

> Also, I would say that the status code check should be verifying if it starts with 5 for http error instead of not starting with 2. I am not...

graphql-tag-pluck can't be configured to ignore gql`...`

Could you create a failing test in a PR? Thanks!

Directive definition is changed from pruning.

Could you create a PR with a failing test? Thanks!

Directive definition is changed from pruning.

PRs are welcome as I already said in my previous PR :) to fix it or at least with a failing test if anyone is interested in.