Arda TANRIKULU comments

Results 597 comments of


                                            Arda TANRIKULU

fix: Unix timestamps are not serialized correctly for scalar DateTime

https://github.com/Urigo/graphql-scalars/pull/2141/files#diff-5bff20d592f8d56ae20cad088bf374d5ce38af414afd5631ab82f42481bb8473L90 This only tests the new behavior but no longer tests the old behavior. Could you update the tests without touching the old tests, then we can merge and release?

Docs - missing scalars (DateTimeISO, LocalDateTime, probably more)

- LocalDateTime is available in the website; https://the-guild.dev/graphql/scalars/docs/scalars/local-date-time - DateTimeISO doesn't have its own page yet but it's mentioned here; https://the-guild.dev/graphql/scalars/docs/scalars/date-time#input-coercion But it is easy to miss because Local Date...

fix: minor spelling errors

Thank you! Could you create a changeset by using `yarn changeset`? Then we can bump the version and release.

fix: minor spelling errors

Thanks

Support GeoJSON types

Sounds cool! PRs are welcome!

Positive BigInt

Feel free to send a PR :)

Hex validator returns invalid hex string

Feel free to create a PR for the fix!

fix(issue-2139): bigint timestamps

This breaks the support for milliseconds, and this would be a breaking change. If we kept the support for ms timestamps, that would be ok.

Passing subscription queries to sources does not work

@germankrause In `source.js`, it uses ApolloServer which uses deprecated `subscriptions-transport-ws` package; See package.json; https://github.com/apollographql/apollo-server/blob/main/packages/apollo-server-core/package.json#L51 See the deprecation note: https://github.com/apollographql/subscriptions-transport-ws/#graphql-ws Since Mesh uses the new `graphql-ws` protocol, you need to upgrade...

[WIP] Added a PlanetScale handler

Closing due to the inactivity! Let us know when you want to proceed.