Arda TANRIKULU

Results 362 comments of Arda TANRIKULU

My concern about `ObjectID` is the bundle size. Treeshaking doesn't work well with `mongodb` package so it increases bundlesize heavily and I don't want to use `ObjectID` from mongodb directly....

What do you mean by extracting code from ObjectID and how do we decide if that is an instance of ObjectID without importing `mongodb`?

The entire GraphQL Scalars package is 90 kB and even 33 kB is too much compared to entire size but all scalars are treeshakable so for example if you use...

@ash0080 Having 'mongodb' as an external dependency doesn't matter. How do you manage non Node environment? Since there is no treeshaking for ObjectID, mongodb will be needed eventually even if...

@ash0080 Personally I couldn't make it fixed in anyways. If you think you can fix it, PRs are always welcome.

@ash0080 Thank you anyway :) and good luck on your new library 🤞 . I am looking forward to seeing it

@ash0080 There are many people using this package in their serverless or client side projects so they need to think about bundle size. That's why, we care about the bundle...

The scenario and your request are different. We can solve that issue by comparing the final coerced value with the input value but this is completely unrelated to removing the...

- As described in the documentation, `DateTime` scalar sticks with UTC. This seems exist in the documentation ![image](https://user-images.githubusercontent.com/20847995/121227512-a6bd4b00-c859-11eb-99d9-7b05dcf8375f.png) Also tests can give some idea; https://github.com/Urigo/graphql-scalars/blob/master/tests/iso-date/DateTime.test.ts - Currency scalar follows ISO-4217...

That sounds cool! Would you create a draft PR for that so we can help you in advance?