SmartEnum icon indicating copy to clipboard operation
SmartEnum copied to clipboard

Add guard clauses for SmartEnum

Open Asafima opened this issue 1 year ago • 5 comments

Added SmartEnumOutOfRange using Ardalis.GuardClauses with two method overloads (int, and generic type).

Closes #528

TODO: Update Readme.md once this pull request is approved and nuget is created.

Asafima avatar Jul 15 '24 15:07 Asafima

@ardalis Hey Ardalis, Saw you tried to merge the pull request. The build fails because of System.Text.Json vulnerability. Do you need me to do anything with this pull request?

Asafima avatar Jul 29 '24 05:07 Asafima

Update System.Text.Json if you have a chance otherwise I'll get to it eventually.

ardalis avatar Jul 29 '24 13:07 ardalis

@ardalis , I have fixed the CS1591 (warning as error).

  1. Do you want me to add a publish-smartenumguardclauses.yml file (using the same template you use for all publish ymls)?
  2. Do you want me to add a README.md to the SmartEnumGuardClauses csproj? or maybe update it to use the main README file?currently no project has a README file baked into it except for SmartEnum.

Asafima avatar Jul 30 '24 05:07 Asafima

@Asafima

  1. Sure that would be helpful.
  2. Your call on the README. Probably good for it to have its own and just link to SmartEnum for more info. Would keep it shorter/simpler.

ardalis avatar Aug 02 '24 15:08 ardalis

@ardalis Awesome. Added github-actions yml file for pipeline, and a readme file for this nuget with references to SmartEnum.

Asafima avatar Aug 04 '24 13:08 Asafima

@ardalis Hey, any new on this PR?

Asafima avatar Aug 19 '24 08:08 Asafima

Thanks!

ardalis avatar Sep 11 '24 18:09 ardalis