wavy icon indicating copy to clipboard operation
wavy copied to clipboard

Support MacOS

Open echelon opened this issue 6 years ago • 5 comments

I recently tried building this on my Mac machine. It works fine on Linux, but failed on the Mac with the following build errors:

error[E0609]: no field `0` on type `&mut system::SpeakerSystem`
  --> /Users/bt/.cargo/registry/src/github.com-1ecc6299db9ec823/wavy-0.1.2/src/system.rs:71:14
   |
71 |         self.0.play(&mut || {
   |              ^

error[E0609]: no field `0` on type `&mut system::MicrophoneSystem`
  --> /Users/bt/.cargo/registry/src/github.com-1ecc6299db9ec823/wavy-0.1.2/src/system.rs:96:14
   |
96 |         self.0.record(generator);
   |              ^

The version of Rust I am running,

rustc --version
rustc 1.37.0 (eae3437df 2019-08-13)
cargo --version
cargo 1.37.0 (9edd08916 2019-08-02)

The Mac version is 10.14.6 (18G87)

The published library version is wavy = "0.1.2"

If I get time I'll look into this, but wanted to give you a head's up.

echelon avatar Sep 06 '19 23:09 echelon

🤦‍♂ I just saw the platform flags in the code and that that Mac support is listed as TODO in the README.

echelon avatar Sep 06 '19 23:09 echelon

Yeah, it's a work in progress. Unfortunately, I don't have a way to test this at the moment (since I don't own a Mac, and I can't get my virtual machine to support audio). Although, currently I have a plan to get it done before the end of this year using my university's computers.

AldaronLau avatar Sep 07 '19 19:09 AldaronLau

Thanks for the super responsive answer! This is already an incredibly valuable crate and I appreciate the functionality already available on Linux.

Depending on the direction my work takes me (I'll eventually need to target iOS), I might wind up in the position to put together a PR.

Thanks!

echelon avatar Sep 10 '19 00:09 echelon

I don’t have the time but I will gladly bow to anybody who makes this PR.

alectrocute avatar Feb 13 '21 13:02 alectrocute

@alectrocute It's getting there, I've been slowly working on it (I have a Mac to test on now) - so, hopefully will be finished in the next few months.

AldaronLau avatar Feb 13 '21 16:02 AldaronLau