arcus.observability icon indicating copy to clipboard operation
arcus.observability copied to clipboard

refactor: Removing all dependency to Guard.NET.

Open joachimgoris opened this issue 9 months ago • 1 comments
trafficstars

As per issue 577. This PR removes all dependency on Guard.NET. All checks done by Guard.NET have been replaced with if checks.

Closes #577

joachimgoris avatar Jan 28 '25 16:01 joachimgoris

Deploy request for arcus-observability pending review.

Visit the deploys page to approve it

Name Link
Latest commit 2a400193b0bac0d124daba38abca9766ec6b1d64

netlify[bot] avatar Jan 28 '25 16:01 netlify[bot]

@stijnmoreels

We should use ArgumentException when checking for blank strings, not ArgumentNullException.

Only when checking for blank strings?

joachimgoris avatar May 22 '25 07:05 joachimgoris

@stijnmoreels

We should use ArgumentException when checking for blank strings, not ArgumentNullException.

Only when checking for blank strings?

We can fallback on ArgumentException for both null, "" and " " inputs.

stijnmoreels avatar May 22 '25 07:05 stijnmoreels

I'm halfway through moving ArgumentNullExceptions to ArgumentException. I've also took the liberty of adding and adapting the following comments

joachimgoris avatar May 22 '25 17:05 joachimgoris

Adapted all the code. Ready for another review

joachimgoris avatar May 22 '25 21:05 joachimgoris