arco-design-vue icon indicating copy to clipboard operation
arco-design-vue copied to clipboard

fix(docs): code tool demo code template icon import

Open hehehai opened this issue 3 years ago • 2 comments

Types of changes

  • [ ] New feature
  • [x] Bug fix
  • [ ] Enhancement
  • [ ] Component style change
  • [ ] Typescript definition change
  • [x] Documentation change
  • [ ] Coding style change
  • [ ] Refactoring
  • [ ] Test cases
  • [ ] Continuous integration
  • [ ] Breaking change
  • [ ] Others

Background and context

like this demo: https://arco.design/vue/component/empty#custom

use <icon-exclamation-circle-fill /> component, but arco icon not import and install global component

Solution

How is the change tested?

Changelog

Type Component Changelog(CN) Changelog(EN) Related issues
fix docs demo 演示代码图标未加载 Demo code icon not loaded -

Checklist:

  • [ ] Test suite passes (npm run test)
  • [ ] Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • [ ] Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others should be submitted to main branch)

Other information

🐝 test the code tool online editor preview read speed no delay, No difference from before

hehehai avatar Jun 25 '22 00:06 hehehai

@hehehai 目前示例代码中没有默认全局引入 Icon 组件,类似的场景是通过在示例中 import 后使用。这里的示例给漏掉了,我来添加一下

flsion avatar Jul 01 '22 10:07 flsion

@hehehai 目前示例代码中没有默认全局引入 Icon 组件,类似的场景是通过在示例中 import 后使用。这里的示例给漏掉了,我来添加一下

@flsion 嗯,这样啊,这里应该不光这一处,有注意到其他 demo 有的也有这个问题,需要过一下

hehehai avatar Jul 01 '22 10:07 hehehai

@flsion 这里需要全局引入吗?不需要的话,我来找一下看那些 demo 有没有引用的吧😃。

hehehai avatar Aug 21 '22 09:08 hehehai