arcnmx
arcnmx
Enjoy my horrible implementation of [programs.starship.extraConfig](https://github.com/arcnmx/nixexprs/blob/f90f7c0a758f2142a448b9e59cc5d6f768b9275b/modules/home/starship.nix), meaniebot. (fwiw, a DAG approach would be quite neat)
eh a DAG is what I'd call interesting, that's a more boring approach :stuck_out_tongue: but sure, it could solve this! (implementation might be a little complicated, plus unlike JSON there...
https://github.com/nix-community/home-manager/issues/2519#issuecomment-1086876577 is still a very intriguing solution, meaniebot
> Is the idea to drop NixString once your impl AsRef for CString lands? That's correct, and why I named the method `as_ref()`. I should add a comment describing that....
Hmmm, now this PR fails because `ToOwned` wasn't implemented for `CStr` until rust 1.3.0... Awkward :( Might have to use a build script to determine version features? I wonder if...
> Not sure what you mean there? We could add some conditional compilation magic into nix_string.rs: 1. If the compiler is older than 1.3.0, don't impl `NixString` on `Cow` 2....
> maybe use the feature name so std_has_cstr_borrow: mm sorry was just testing on CI. It's probably something that should go in its own PR anyway. > make a PR...
So as it turns out, #247 makes up the bulk of the changes. c43753350cb7b1465a56858fc4ee4b2bdaab1c31 is the change on top of that.
Rebased. The title still applies.
Note that the `cstr` module is mostly for concenience to ease the transition, and used in the tests for that purpose. I'd suggest maybe pulling it out as a separate...