MaterialThemeGenerator icon indicating copy to clipboard operation
MaterialThemeGenerator copied to clipboard

Demo in shrable link dont work

Open giovannidias1 opened this issue 2 years ago • 4 comments

When i create a theme and try share this my changes in demo does not appear

Link

giovannidias1 avatar Apr 27 '22 14:04 giovannidias1

Something appears to be incompatible with the sizing {status: 1, file: @.***/material/theming', line: 4297, column: 27, message: "Incompatible units: 'px' and 'em'.", …}

I just attempted a new style/share link, and this is not occurring. I'm at work now, so I will need to check later and I can get back to you.

On Wed, Apr 27, 2022 at 10:36 AM GIovanni Dias @.***> wrote:

When i create a theme and try share this my changes in demo does not appear

Link https://materialtheme.arcsine.dev/?c=YHBhbGV0dGU$YHByaW1hcnk$YF48I2E2NjZiNSIsIj9lcjwjYzQ5YWNlIiwiO2VyPCM2ZTNiN2F$LCIlPmBePCMwMDk5OGMiLCI~ZXI8IzQzYmZiMyIsIjtlcjwjMDA2NjVkfiwid2Fybj5gXjwjOWExOTE1IiwiP2VyPCNlMWJhYjkiLCI7ZXI8IzdlMGUwY34sIj9UZXh0PCMzZDNkM2QiLCI~PTwjZmZmZmZmIiwiO1RleHQ8I2ZmZmZmZiIsIjs9PCMwMDAwMDB$LCJmb250cz5bYEA8KC00IiwiZmFtaWx5PE1vbnRzZXJyYXQiLCJzaXplPjk2LCJzcGFjaW5nPi0xNX0sYEA8KC0zIiwiZmFtaWx5PE1vbnRzZXJyYXQiLCJ2YXJpYW50PD8iLCJsaW5lSGVpZ2h0PjcyLCJzaXplPjYwLCJzcGFjaW5nPi04fSxgQDwoLTIiLCJmYW1pbHk8TW9udHNlcnJhdCIsImxpbmVIZWlnaHQ$NTYsInNpemU$NDh9LGBAPCgtMSIsImZhbWlseTxNb250c2VycmF0IiwibGluZUhlaWdodD4zNiwic3BhY2luZz4wfSxgQDxoZWFkbGluZSIsImZhbWlseTxNb250c2VycmF0IiwidmFyaWFudDxtZWRpdW1$LGBAPHRpdGxlIiwiZmFtaWx5PE1vbnRzZXJyYXQiLCJsaW5lSGVpZ2h0PjI0LCJzaXplPjE2LCJzcGFjaW5nPjcuNX0sYEA8c3ViKS0yIiwiZmFtaWx5PE1vbnRzZXJyYXQiLCJ2YXJpYW50PG1lZGl1bSIsImxpbmVIZWlnaHQ$MjQsInNwYWNpbmc$MH0sYEA8c3ViKS0xIiwiZmFtaWx5PE1vbnRzZXJyYXQiLCJsaW5lSGVpZ2h0PjI1LCJzaXplPjE0LCJzcGFjaW5nPjd9LGBAPGJvZHktMiIsImZhbWlseTxPcGVuIFNhbnMiLCJsaW5lSGVpZ2h0PjI2LCJzaXplPjE2LCJzcGFjaW5nPjB9LGBAPGJvZHktMSIsImZhbWlseTxPcGVuIFNhbnMiLCJsaW5lSGVpZ2h0PjI2LCJzcGFjaW5nPjB9LGBAPGJ1dHRvbiIsImZhbWlseTxPcGVuIFNhbnMiLCJsaW5lSGVpZ2h0PjE2LCJzcGFjaW5nPjB9LGBAPGNhcHRpb24iLCJmYW1pbHk8T3BlbiBTYW5zIiwibGluZUhlaWdodD4xNiwic3BhY2luZz4wfSxgQDxpbnB1dCIsImZhbWlseTxPcGVuIFNhbnMiLCJsaW5lSGVpZ2h0PjE2LCJzaXplPjE2LCJzcGFjaW5nPjB9XSwiaWNvbnM8T3V0bGluZWQiLCI~bmVzcz50cnVlLCJ2ZXJzaW9uPjExfQ%3D%3D

— Reply to this email directly, view it on GitHub https://github.com/arciisine/MaterialThemeGenerator/issues/50, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJUUL2R5D6TQ3CQ5GIVTBTVHFGGZANCNFSM5UPLK4RQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

arciisine avatar Apr 27 '22 18:04 arciisine

When trying to copy the generated scss it also accuses errors between em and px

Error: Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
SassError: 0.6666666667em and 16px have incompatible units.
    ╷
164 │   $wrapper-padding-bottom: ($subscript-margin-top + $line-height) * $subscript-font-scale;
    │                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ╵

from what I realized the problem is in the fonts specifically in the line-height

when i commented this line, worked fine

// headline: mat.define-typography-level(24px, 32px, 500, 'Montserrat', 0.0000em),

giovannidias1 avatar Apr 28 '22 13:04 giovannidias1

I found the problem, the problem is when you are setting values in Input, input does not support values in PX and EM, but it is possible to edit these values in the editor

giovannidias1 avatar Apr 28 '22 17:04 giovannidias1

Thanks for rooting out the issue. I'll need to figure out if em/rem units are possible here, or if it only supports physical units (pt/px). Once I figure it out, I will update accordingly.

arciisine avatar May 04 '22 12:05 arciisine