[4.x] Finish incomplete and missing tests
This PR completes the missing/skipping tests. Now there is only one skipping test related to the Debuggable feature. As discussed internally, this feature is still incomplete, so I left the test as it is.
Codecov Report
Merging #947 (8ff1e45) into master (abd17f8) will decrease coverage by
0.10%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #947 +/- ##
============================================
- Coverage 87.34% 87.23% -0.11%
- Complexity 408 411 +3
============================================
Files 112 113 +1
Lines 1130 1136 +6
============================================
+ Hits 987 991 +4
- Misses 143 145 +2
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...e/TenantDatabaseManagers/SQLiteDatabaseManager.php | 76.47% <100.00%> (-8.15%) |
:arrow_down: |
| src/Listeners/DeleteTenantStorage.php | 100.00% <0.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
The ternary I told you to convert to a proper if check — don't overcomplicate it. You're using str() just to join strings and then you have to call ->toString() at the end. That just adds complexity.
Also, the comments aren't needed.
All you need to do there is just change the ternary into an if () and the code will be perfect.