archwiki icon indicating copy to clipboard operation
archwiki copied to clipboard

Remove unused file LocalSettings.archlinux.org.php

Open lahwaacz opened this issue 5 years ago • 4 comments

The main LocalSettings.php file is actually public (except for the secret values) in the Arch infrastructure repository: https://gitlab.archlinux.org/archlinux/infrastructure/-/blob/master/roles/archwiki/templates/LocalSettings.php.j2

The LocalSettings.php.j2 template includes clear configuration for the database access and memcached, so these comments and settings are not needed here anymore.

Actually, I'm thinking that we should move this entire file to the infrastructure repository to keep all settings in one place. It would also allow easier configuration of a testing wiki in local containers and in the future it would allow us to run ArchWiki based on packages instead of a monolithic git repo which is rather hard to update.

CC @kynikos, @nl6720, @jelly, @grazzolini: what do you think guys?

lahwaacz avatar Aug 24 '20 16:08 lahwaacz

For us to be able to use a packaged wiki, we would need a way to apply Arch specific stuff on top of it. Or, alternatively, have an archwiki package. I don't think we need to put all of the conf into the infra repo, specially if it's not something we need to change.

grazzolini avatar Aug 24 '20 16:08 grazzolini

If I'm not missing anything, the only Arch-specific things here are:

  • favicon.ico
  • LocalSettings.archlinux.org.php
  • the ArchLinux extension (i.e. the skin)
  • the FluxBBAuth extension (actually unused on wiki.archlinux.org, maybe @pierres uses it on wiki.archlinux.de or somewhere else?)
  • the docker subdirectory (which is obviously only testing)

The rest should be vanilla MediaWiki and its extensions which can be easily packaged. @nl6720 already created some packages for extensions in the AUR. We didn't need to modify the MediaWiki core for a long time.

lahwaacz avatar Aug 24 '20 20:08 lahwaacz

Actually, I'm thinking that we should move this entire file to the infrastructure repository to keep all settings in one place.

See https://gitlab.archlinux.org/archlinux/infrastructure/-/merge_requests/516.

nl6720 avatar Dec 21 '21 12:12 nl6720

@nl6720 I've reworked the pull request accordingly. Thanks for taking care of the config file migration! :tada:

lahwaacz avatar Jul 03 '22 13:07 lahwaacz