archinstall
archinstall copied to clipboard
archlinux
Add missing xdg-user-dirs and Cosmic Greeter
Installing Cosmic as is results in no greeter so service needs to be started. Also added missing xdg-user-dirs for user directories in cosmic-file-manager..
Thank you for these fixes. Is
xdg-user-dirsstrictly necessary for cosmic to function? I thought that package only created some well known folders, that from previous issues/PR have been requested to be removed IIRC.
Removed ? Why ? This is the norm for DEs except thunar.. It's been the way file managers worked since ever..
I can't see that package mentioned as requested in the wiki https://wiki.archlinux.org/title/COSMIC also not in the cosmic package group
I can't see that package mentioned as requested in the wiki https://wiki.archlinux.org/title/COSMIC also not in the cosmic package group
Remember it's Alpha so could have been missed.. Doesn't mean it shouldn't be there.. Again if a few kb hurt you then in my opinion desktop profiles should be killed off in ArchInstall let users choose what they want instead of offering opinionated and incomplete ones.
The point is that we need to be able to point to something when someone else comes along and complains "why is this package being installed". Having a clear source to point to is something valuable, with the wiki being the general source to follow.
In addition, what is CosmicGreeter ? That hasn't been defined at all
The point is that we need to be able to point to something when someone else comes along and complains "why is this package being installed". Having a clear source to point to is something valuable, with the wiki being the general source to follow.
In addition, what is
CosmicGreeter? That hasn't been defined at all
I guess you are getting a lot of "bloat" sensitive people complaining.. Well you can just tell them xdg-user-dirs is what enables user folders to show up in file manager side panel without it they will not be there. If they complain again just ignore them way I do coz if they dislike the way things are they can either remove the so called "bloat" and move on or stop using Linux n go back to what suits their need better..
What is cosmic greeter ? You must be kidding me right ? It's the greeter for cosmic it's included if you look close. It's just it's not being enabled via ArchInstall..
My point was it's not defined in the code.
What the greeter ? If so it's coz they done goofed, it's still in Alpha. If we were talking final product I would understand. Logically why even bother shipping cosmic greeter if you ain't gonna bother enabling it ? But hey am done suggesting anything since you are going to question everything making us feel guilty for doing so.
I am not a user, I am a distro maintainer, part of my job is to study the Linux community and how various things are being used, how users use their systems and what is most commonly installed.. But hey ignore me and my "unconventional" suggestions.. You do you, I will keep creating scripts that bypass the ArchInstall profiles section..
But hey ignore me and my "unconventional" suggestions.. You do you, I will keep creating scripts that bypass the ArchInstall profiles section..
This general tone is for me unacceptable. Part of maintaining something, is to interact with others. This means interacting socially in a way that is pleasant for everyone!
And this is where I find your "you do you" unacceptable, because what @svartkanin is trying to do, is help you understand that your code has a few flaws that needs adjusting before we can merge this without breaking changes.
You either don't understand Python (judging by looking at your GitHub projects), which is fine, or you just don't respond well to criticism. Because as @svartkanin pointed out:
In addition, what is CosmicGreeter ? That hasn't been defined at all
- https://github.com/archlinux/archinstall/blob/5a4773cdd312bf65220af6853c222c01f53a8296/archinstall/default_profiles/profile.py#L30-L39
There's no CosmicGreeter type defined in our type cluster. Thus if you try to access GreeterType.CosmicGreeter you will get:
Again, these are all fixable stuff.. But the way you respond to questions from the community and the developers trying to guide you to a complete PR is tempered and short.
And your recommendations on how to handle community feedback in the manner of:
If they complain again just ignore them way I do
Is not really what we're about. We're trying to be inclusive, both to you and to others. That means allowing people to have opinions, as long as they themselves are inclusive.
All that said, which I really shouldn't have to tell another person, because people should understand that being respectful and patient with each other is a basic human thing to do..
Adding xdg-user-dirs has been discussed in the past:
- https://github.com/archlinux/archinstall/issues/594
- https://github.com/archlinux/archinstall/issues/2587
- https://github.com/archlinux/archinstall/issues/2507
And there hasn't been much objections, so I'd say we could add it and see what the response would be like, with the limitation of it being added for desktop profiles (even for certain desktop profiles since most desktop users differ in their taste.. awesome for instance don't need it really IMHO as it's a WM not a DE).
But GreeterType.CosmicGreeter needs to be reverted, or fully added as it's breaking Python code at the moment.
Until then, refrain from passive aggressive language, or language with finality statements such as "kill profiles in archinstall" as these are counter productive.
@Torxed
I do not understand python no, never pretended that I did. And am sorry if I was aggressive, but you understand I was sort of criticized for suggesting what I did. As for the Greeter I always wondered why it was included and not being enabled thank you for explaining it. I was just pointing it out.
User dirs is fine with or without, I came here on the behest of some of my users who, when I mentioned why I skip profiles when I use ArchInstall asked me to report it here for them.. Is all..
Feel free to revert the greeter code, and thus only adding the user dirs. That way we can merge this. Then if you're open for learning and discussing the greeter fix, we can do that in a separate PR.
Or, we can discuss how to fix the Python code here, that's fine too. It's up to you really. These are just two viable options.
@Torxed
Since I am not a dev, I wouldn't know where to begin that's why I suggested it here. You are the brains of the operation. Although I maintain a full Distro, I do that to the best of my non-dev abilities and it has worked out well for me for the past 5 years or so.
Forgive my ignorance when I reported I thought it was just a matter of including an option that enables the service since that was all that I needed to do for it to work post-install but from my understanding now it is way more involved than that.. Hmm.. Well in my Cosmic install I just added sudo systemctl enable cosmic-greeter which works..
Well in my Cosmic install I just added sudo systemctl enable cosmic-greeter which works..
I believe that should be systemctl --user enable cosmic-greeter right?
@Torxed Well I dunno really haven't looked too deeply into it I just use general one I mentioned and it works since in my mind it should be system wide not just for that user. But maybe you are right I got no clue.