archinstall icon indicating copy to clipboard operation
archinstall copied to clipboard

Change "Formatting /dev/sdX in ..." message if nothing will actually be formatted

Open trustytrojan opened this issue 1 year ago • 1 comments

I got a scare when I saw the "Formatting in 5..." message even though I setup the partitions such that none of them said "create" or "modify" in the table shown by archinstall. I would definitely prefer that the message only be shown if anything will actually be formatted...

Here's the print statement of the "Formatting" message: https://github.com/archlinux/archinstall/blob/master/archinstall%2Flib%2Fdisk%2Ffilesystem.py#L49

And here's where partitions are filtered for "create" or "modify" partitions: https://github.com/archlinux/archinstall/blob/master/archinstall%2Flib%2Fdisk%2Ffilesystem.py#L98-L99

This isn't a crucial issue but I feel it could prevent headaches for many users.

trustytrojan avatar Nov 07 '24 00:11 trustytrojan

Yes this freaked me out lol

andreyrd avatar May 30 '25 17:05 andreyrd