archinstall
archinstall copied to clipboard
Excessive partition table commits
The logic in the code below will cause the partition table to be written to disk and the operating system kernel to be informed on each iteration of the for loop. Instead this should be done once, after all changes have been made to the partition table layout.
https://github.com/archlinux/archinstall/blob/f107104103b74ac065a56bd94a0878f0d263e177/archinstall/lib/disk/device_handler.py#L534-L538
https://github.com/archlinux/archinstall/blob/f107104103b74ac065a56bd94a0878f0d263e177/archinstall/lib/disk/device_handler.py#L341-L342
https://github.com/archlinux/archinstall/blob/f107104103b74ac065a56bd94a0878f0d263e177/archinstall/lib/disk/device_handler.py#L380-L381