archinstall icon indicating copy to clipboard operation
archinstall copied to clipboard

Update locale files with ./locales_generator.sh to be current

Open JoelLarson opened this issue 3 years ago • 0 comments

Update locale files with locales_generator.sh

The locales directory has become out of date. This PR updates the files by running ./locales_generator.sh with no additional changes.

This change is to simplify https://github.com/archlinux/archinstall/pull/1341

JoelLarson avatar Jul 11 '22 14:07 JoelLarson

Apologies for the delay, I've waited with merging in the translations as we've moved around a lot of other stuff in prep for release.

Looking at this, to the untrained eye, what's the difference to #1341? Is the only difference that you've executed ./locales_generator.sh before translating and the other one did not?

Torxed avatar Sep 02 '22 10:09 Torxed

Yep! The Danish translations PR updated most of the Russian translations. This PR was to make it easier to review to make #1341 easier to merge.

JoelLarson avatar Sep 05 '22 23:09 JoelLarson

I'm not sure this specific PR is required as a lot of other languages pulled in these updates as well. Could you rebase with master and check? Otherwise we can close this and do the same for the other PR :)

Torxed avatar Sep 06 '22 06:09 Torxed

@Torxed I've regenerated the changes with the latest. There were a few changes that were made in each file. #1341 will require more than a rebase.

JoelLarson avatar Sep 09 '22 00:09 JoelLarson

Github actions could be used for adding a check to make sure they are always current.

JoelLarson avatar Sep 09 '22 00:09 JoelLarson

Thanks! Yea there's always room for improvement, feel free to submit a PR for that if you wish :) Otherwise I'll have to add it to my pile sadly.

Torxed avatar Sep 09 '22 07:09 Torxed

I can work on that when I find some time.

JoelLarson avatar Sep 10 '22 05:09 JoelLarson