warclight

warclight copied to clipboard

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request. ### What changed?...

depfu[bot]

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request. ### What changed?...

depfu[bot]

We've tried to upgrade a dependency and got errors running Bundler. It looks like there is a version conflict between two or more dependencies. Depfu doesn't try to solve these,...

depfu[bot]

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request. ### What changed?...

depfu[bot]

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request. ### What changed?...

depfu[bot]

Currently we're ignoring this in Rubocop. We shouldn't. ``` Offenses: app/models/concerns/warclight/solr_document.rb:12:32: C: Rails/TimeZone: Do not use Time.parse.strftime without zone. Use one of Time.zone.parse.strftime, Time.current, Time.parse.strftime.in_time_zone, Time.parse.strftime.utc, Time.parse.strftime.getlocal, Time.parse.strftime.iso8601, Time.parse.strftime.jisx0301, Time.parse.strftime.rfc3339,...

ruebot

Currently we're ignoring this in Rubocop. We shouldn't. ``` Offenses: app/models/concerns/warclight/solr_document.rb:9:5: C: Metrics/AbcSize: Assignment Branch Condition size for replay_link is too high. [20.12/15] def replay_link ```

ruebot

Since we've added the helper method, we lost the ability have `link_to_facet`. We should add this functionality back.

ruebot