archivesspace icon indicating copy to clipboard operation
archivesspace copied to clipboard
verified publisher icon archivesspace

ANW-1651: adding translations for archival record relators in EAD

Open avatar382 opened this issue 2 years ago • 3 comments

Description

Untranslated enum values are showing up in the staff generated PDFs, which are taken from the EAD record. Adding translations to the EAD results in the translations appearing in the PDF.

Related JIRA Ticket or GitHub Issue

https://archivesspace.atlassian.net/jira/software/c/projects/ANW/issues/ANW-1651

How Has This Been Tested?

Manual testing

Screenshots (if appropriate):

Screenshot_2023-06-15_10-01-25 Screenshot_2023-06-15_10-03-33 Screenshot_2023-06-15_10-03-54

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [x] I have read the CONTRIBUTING document.
  • [x] I have authority to submit this code.
  • [ ] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

avatar382 avatar Jun 15 '23 16:06 avatar382

I haven't tested it, but wouldn't this break the ability to export EAD from ArchivesSpace, make changes, and re-import into ArchivesSpace? Well, not break it exactly, but fill up the linked_agent_archival_record_relators controlled value list with duplicate entries (e.g. both "dnr" and "Donor", both "act" and "Actor", etc.) And those new values wouldn't have translations, so the next time the record is exported, or a staff PDF generated, you might get "translation missing" in the output.

Also, some ArchivesSpace members use the EAD export (via OAI-PMH) to populate alternative public interfaces (e.g. ArcLight). Those systems might be expecting MARC relator codes, not translated labels.

andrew-morrison avatar Jul 04 '23 13:07 andrew-morrison

@andrew-morrison Thanks for the heads-up on that. We'll have to make sure someone tests that before we consider merging.

donaldjosephsmith avatar Sep 18 '23 18:09 donaldjosephsmith

Could this be addressed on the PDF transformation layer by by dynamically generating an xsl:map from the enumeration yml that the xsl-fo transformation can in turn use to pull translations from?

regineheberlein avatar Apr 30 '24 17:04 regineheberlein

Closing this as it has been implemented in: https://github.com/archivesspace/archivesspace/pull/3223

thimios avatar May 30 '24 13:05 thimios