architectury-api icon indicating copy to clipboard operation
architectury-api copied to clipboard

[1.20.1] LIVING_CHECK_SPAWN event overrides PortingLib's version of the same event

Open TheWinABagel opened this issue 1 year ago • 1 comments

Porting lib uses ModifyExpressionValue, (see here) which is overriden by this this redirect https://github.com/architectury/architectury-api/blob/cd74016d85b562affb21890cb8796b1e34ac2ca9/fabric/src/main/java/dev/architectury/mixin/fabric/MixinNaturalSpawner.java#L40 Changing this from a redirect to a Mixin extras ModifyExpressionValue would solve this incompatibility as the event would chain instead

TheWinABagel avatar Mar 21 '24 05:03 TheWinABagel

The ModifyExpressionValue will already modify the result of this redirect. They already chain.

LlamaLad7 avatar Mar 21 '24 13:03 LlamaLad7