architectury-api icon indicating copy to clipboard operation
architectury-api copied to clipboard

Registry Replacements (#430)

Open qyl27 opened this issue 1 year ago • 4 comments

Replace vanilla items with register() on fabric.
(Tested on my machine.)

qyl27 avatar Sep 21 '23 15:09 qyl27

Hmm, honestly I would prefer if registry replacement was explicit on both instead of implicit, so maybe we should instead consider making a registerOrOverride method?

MaxNeedsSnacks avatar Jan 07 '24 13:01 MaxNeedsSnacks

Hmm, honestly I would prefer if registry replacement was explicit on both instead of implicit, so maybe we should instead consider making a registerOrOverride method?

Well, maybe that's right.
I will change it to a explicit method named registerOrOverride.

qyl27 avatar Jan 07 '24 14:01 qyl27

After some discussion on Discord, I believe we don't want to support registry replacements seeing how NeoForge no longer supports it after the Registry Rework and fabric never encouraged it. Alternative solutions should be used instead, albeit mixins or etc.

Some checks can be added to the forge register() method to warn potential registry replacements instead.

shedaniel avatar Jan 10 '24 01:01 shedaniel

After some discussion on Discord, I believe we don't want to support registry replacements seeing how NeoForge no longer supports it after the Registry Rework and fabric never encouraged it. Alternative solutions should be used instead, albeit mixins or etc.

Some checks can be added to the forge register() method to warn potential registry replacements instead.

Ah, okay.

qyl27 avatar Jan 10 '24 01:01 qyl27

After some discussion on Discord, I believe we don't want to support registry replacements seeing how NeoForge no longer supports it after the Registry Rework and fabric never encouraged it. Alternative solutions should be used instead, albeit mixins or etc.

Some checks can be added to the forge register() method to warn potential registry replacements instead.

Jab125 avatar Apr 13 '24 05:04 Jab125