architectury-api icon indicating copy to clipboard operation
architectury-api copied to clipboard

Unable to register a ConfiguredFeature in 1.19.3

Open Wilyicaro opened this issue 3 years ago • 6 comments

Caused by: java.lang.ClassNotFoundException: dev.architectury.registry.registries.Registries at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520) at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:226) at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:145) Caused by: java.lang.ClassNotFoundException: dev.architectury.registry.registries.Registries

  at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
  ... 14 more

Caused by: java.lang.NullPointerException: Registry ResourceKey[minecraft:root / minecraft:worldgen/configured_feature] not found! at java.base/java.util.Objects.requireNonNull(Objects.java:233) Caused by: java.lang.NullPointerException: Registry ResourceKey[minecraft:root / minecraft:worldgen/configured_feature] not found!

at dev.architectury.registry.registries.fabric.RegistrarManagerImpl$RegistryProviderImpl.get(RegistrarManagerImpl.java:78) at dev.architectury.registry.registries.RegistrarManager.get(RegistrarManager.java:52) at dev.architectury.registry.registries.DeferredRegister.getRegistrar(DeferredRegister.java:90) at dev.architectury.registry.registries.DeferredRegister.register(DeferredRegister.java:74)

ConfiguredFeature register method has been changed, and apparently no longer uses a Registry<T>

Wilyicaro avatar Dec 16 '22 23:12 Wilyicaro

Yes, ConfiguredFeature is now purely a datapack registry, and BuiltinRegistries no longer exists, so you cannot use DeferredRegisters for registering them anymore either. We're still dealing with the fallout of this change ourselves, and you might see changes in Architectury that may allow you to register datapack registry contents through code still (as that is still a valid use case for, say, dynamically generated code-based features)

MaxNeedsSnacks avatar Dec 17 '22 00:12 MaxNeedsSnacks

I noticed this shortly afterwards, however from what I saw the vanilla Placed Features and Configured Features are still registered in a different way in the game code, using the BootstapContext<> to get it

Wilyicaro avatar Dec 17 '22 12:12 Wilyicaro

Unfortunately, the whole bootstrapping and RegistryBuilder concept is only used for datagen

MaxNeedsSnacks avatar Dec 17 '22 12:12 MaxNeedsSnacks

Very sad to have to redo everything in .json or wait for an alternative

Wilyicaro avatar Dec 17 '22 12:12 Wilyicaro

A similiar error causes my game to crash on mod loading: crash-2023-01-18_15.55.38-client.txt

Zemogiter avatar Jan 18 '23 15:01 Zemogiter

same error Caused by: java.lang.NullPointerException: Registry ResourceKey[minecraft:root / minecraft:worldgen/configured_feature] not found!

Maks-gaming avatar Oct 24 '23 18:10 Maks-gaming