architectury-api icon indicating copy to clipboard operation
architectury-api copied to clipboard
verified publisher icon architectury

Fix chat events

Open shedaniel opened this issue 3 years ago • 5 comments

  • This fixes chat events on fabric due to Fabric API taking priority above our mixins, we inject to the same place
  • Test mod now with appended "new text" for server chat modifications and "error:" for client chat modifications
  • Forge event now not cancelled for client chat modifications

shedaniel avatar Jul 16 '22 09:07 shedaniel

Superseded by #302

MaxNeedsSnacks avatar Jul 28 '22 13:07 MaxNeedsSnacks

We still need this

shedaniel avatar Aug 06 '22 02:08 shedaniel

In that case, see my comments regarding the cancelling component ^^ There has to be a better way to do that :/

MaxNeedsSnacks avatar Aug 06 '22 14:08 MaxNeedsSnacks

Please resolve the merge conflicts so this can be put on last call

MaxNeedsSnacks avatar Sep 04 '22 21:09 MaxNeedsSnacks

Is there still enough demand for 1.19 to warrant fixing this issue? The discourse(TM) regarding that version has largely died down, and due to CurseForge's horrible UX I would even say that publishing a new 1.19.0 release would likely confuse users into downloading said new version for their 1.19.2 instance

MaxNeedsSnacks avatar Oct 20 '22 12:10 MaxNeedsSnacks