sandbox icon indicating copy to clipboard operation
sandbox copied to clipboard

Only use valid characters in dummy AWS access keys

Open lpsinger opened this issue 9 months ago • 2 comments

Only use letters and numbers in dummy AWS access keys. Access keys that contain underscores are invalid.

This is required for using Architect with DynamoDB Local.

See notes section of https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/DynamoDBLocal.DownloadingAndRunning.html.

Thank you for helping out! ✨

We really appreciate your commitment to improving Architect

To maintain a high standard of quality in our releases, before merging every pull request we ask that you've completed the following:

  • [ ] Forked the repo and created your branch from main
  • [ ] Made sure tests pass (run npm it from the repo root)
  • [ ] Expanded test coverage related to your changes:
    • [ ] Added and/or updated unit tests (if appropriate)
    • [ ] Added and/or updated integration tests (if appropriate)
  • [ ] Updated relevant documentation:
  • [ ] Summarized your changes in changelog.md
  • [ ] Linked to any related issues, PRs, etc. below that may relate to, consume, or necessitate these changes

Please also be sure to completed the CLA (if you haven't already).

Learn more about contributing to Architect here.

Thanks again!

lpsinger avatar Mar 17 '25 19:03 lpsinger

CI failures look like they are probably unrelated.

lpsinger avatar Mar 17 '25 19:03 lpsinger

Hey thanks for the PR! I think the build is failing in this project at the moment, but I think there is a fix on the way in #736.

filmaj avatar Mar 18 '25 03:03 filmaj