functions icon indicating copy to clipboard operation
functions copied to clipboard

Static fullmanifest

Open ryanbethel opened this issue 4 years ago • 3 comments

This is for the feature request for full static manifest

I thought it would be easier to just make a pull request to illustrate what I am suggesting instead of trying to describe it in detail in a feature request. If this is not a desired feature I am fine to drop it.


To maintain a high standard of quality in our releases, before merging every pull request we ask that you've completed the following:

  • [x] Forked the repo and created your branch from master
  • [ ] Made sure tests pass (run npm it from the repo root)
    • One discovery test does not pass even before making any changes. Probably related to my setup. I will try to figure that out before finalizing this.
  • [x] Expanded test coverage related to your changes:
    • [x] Added and/or updated unit tests (if appropriate)
    • [ ] Added and/or updated integration tests (if appropriate)
  • [x] Updated relevant documentation:
    • [x] Internal to this repo (e.g. readme.md, help docs, inline docs & comments, etc.)
    • [ ] Architect docs (arc.codes)
    • I will add changes to arc.codes docs if it looks like feature will be accepted. I will wait for initial feedback.
  • [x] Summarized your changes in changelog.md
  • [x] Linked to any related issues, PRs, etc. below that may relate to, consume, or necessitate these changes

Please also be sure to completed the CLA (if you haven't already).

Learn more about contributing to Architect here.

Thanks again!

ryanbethel avatar Jul 03 '21 13:07 ryanbethel

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 03 '21 13:07 CLAassistant

lets add a new method rather than overloading this one; how about arc.static.manfiest ?

brianleroux avatar Jul 19 '21 20:07 brianleroux

lets add a new method rather than overloading this one; how about arc.static.manfiest ?

That seems like a good idea.

It might be a good opportunity to add the missing feature to generate a manifest (output) if fingerprinting is turned off. Seems like we could list all files in the public bucket to build a manifest if the static.json is not present. Not sure what the performance for it is compared to just getting the static.json (slower I'm sure, but by how much). But it would likely not be run too frequently.

ryanbethel avatar Jul 19 '21 20:07 ryanbethel