dynalite icon indicating copy to clipboard operation
dynalite copied to clipboard

Changing (or dropping) https support

Open ryanblock opened this issue 1 year ago • 3 comments

Currently, Dynalite supports https connections with an ssl option; you can pass it key, cert, and ca options, or Dynalite will read its own default keys.

Unfortunately, Dynalite's own keys have apparently expired, and with a major release coming up in the future this would be a good opportunity to alter this behavior.

With Sandbox (our other local AWS emulator), time and time again we've looked at adding https to our API Gateway emulation. Each time we arrive at the conclusion that it's way more trouble than it's worth (especially given the local dev context).

My preference would be to drop support entirely, but if folks do indeed make use of this feature, at very least I'd like to change support to a) you must supply a key, cert, and ca (or file paths to them), and b) we will not be offering any support for this feature.

Thoughts?

ryanblock avatar Sep 04 '23 20:09 ryanblock

At the very least we should stop passing the options object into the https.createServer directly and either leave it with the keys only, or support passing options into both http servers. Eg, port as an option only works with ssl enabled today.

reconbot avatar Sep 04 '23 20:09 reconbot

That's legit, and worthy of a separate issue imo.

ryanblock avatar Sep 04 '23 21:09 ryanblock

Will leave this PR open until tomorrow to get additional feedback, then move on. I'd love to try and have 4.0 out sometime this week.

ryanblock avatar Sep 05 '23 17:09 ryanblock